Avoid parsing nested jar URLs for cached resource lookups - #51827
Open
sharanrenukeshbharmshetty wants to merge 1 commit into
Open
sharanrenukeshbharmshetty wants to merge 1 commit into
sharanrenukeshbharmshetty wants to merge 1 commit into
Conversation
Construct JarFileUrlKey directly from already-parsed URL specification to avoid unnecessary URL construction and parsing on cache hits. A URL is only created on a cache miss when the JarFile needs to be instantiated. This eliminates redundant object allocation in the hot path when frameworks probe for optional classes or package-info metadata across a large executable JAR. Closes spring-projectsgh-51503 Signed-off-by: sharanrenukeshbharmshetty <sbharmshetty@gmail.com>
sharanrenukeshbharmshetty
force-pushed
the
sharan-first-contribution
branch
from
September 17, 2026 17:15
7a78a19 to
8fad6eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct JarFileUrlKey directly from already-parsed URL specification to avoid unnecessary URL construction and parsing on cache hits. A URL is only created on a cache miss when the JarFile needs to be instantiated.
This eliminates redundant object allocation in the hot path when frameworks probe for optional classes or package-info metadata across a large executable JAR.
Closes gh-51503