fix(sqlite): allow to use overrides for columns which were created using "alter table .. add column"#4447
Open
leonklingele wants to merge 2 commits into
Open
Conversation
…verwrite follow-up fix
…ing "alter table .. add column"
This fixes the failing test which was added in the previous commit.
Normalize sqlite `ALTER TABLE` column identifiers and preserve analyzer
origin metadata when merging query analysis. This allows exact column
overrides such as `chat_messages.updated_at` to match columns added via
`ALTER TABLE .. ADD COLUMN`.
Using the sqlc config:
overrides:
- column: "*.*_at"
go_type:
import: "time"
type: "Time"
and the SQL schema:
CREATE TABLE chat_messages (
id TEXT PRIMARY KEY NOT NULL,
body TEXT NOT NULL,
created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP
) STRICT;
ALTER TABLE chat_messages ADD COLUMN "updated_at" TEXT NOT NULL DEFAULT '';
sqlc would previously generate the following code:
type ChatMessage struct {
ID string
Body string
CreatedAt time.Time
UpdatedAt string // Bug: This should be a time.Time!
}
_With_ this fix, the following code is generated:
type ChatMessage struct {
ID string
Body string
CreatedAt time.Time
UpdatedAt time.Time // Fixed, now a time.Time, even for retroactively added columns
}
9f770c1 to
3c4ff4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a failing test which is then fixed by a follow-up commit.
Normalize sqlite
ALTER TABLEcolumn identifiers and preserve analyzerorigin metadata when merging query analysis. This allows exact column
overrides such as
chat_messages.updated_atto match columns added viaALTER TABLE .. ADD COLUMN.Using the sqlc config:
and the SQL schema:
sqlc would previously generate the following code:
With this fix, the following code is generated: