Repository navigation
fix(assistant): provide reviewed SNA field overview - #186
Merged
Merged
Conversation
lweberru
marked this pull request as ready for review
October 29, 2026 14:02
lweberru
requested review from
Breeless,
JoshSTACKIT,
LembDo and
dweezl
as code owners
October 29, 2026 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qualified Dev release of #185 stopped at
stackit-network-components-advice(invalid_scope): 169/170 cases and 13/13 journey steps passed; build and deployment were skipped. The original rejected model body was not retained, so its exact cause remains unknown. A separate diagnostic showed that correctly classified SNA field advice still used a second free-form generation with unrelated content and setup questions.Add a reviewed, bounded SNA overview to the existing field-advice route. It covers native single/map/regional forms, ordered IPv4 prefixes, resolver defaults, Corporate references and capacity limits without questions or changes. Existing draft/history/scope guards remain intact. Strengthen overview qualification to require native fields and reject setup questionnaires. Regenerate catalogue metadata and update English/German documentation.
Validation on final head
6c3ddc4dcd4ec83201dae2e1d29f7cd8ee0dc9fd: full app check 1,615 passed, 76 conditional/environment skips in two files; targeted real-model case 2/2 and continuous journey 13/13 passed; catalogue current. Independent review found one missing native-sizing source binding, fixed and regenerated; final review has no findings. Added a negative oracle regression proving an otherwise complete overview with a setup question is rejected. All applicable final-head CI checks passed, including desktop/mobile browser acceptance and isolated recovery lab. The first local check was interrupted in the restricted process/loopback sandbox; its output is retained separately and not counted as a pass.Full protected qualification is required before Dev build/deployment; failed release 40880958885 remains a failure. The original rejected response is unavailable; a diagnostic is not qualification evidence. No customer Plan, Apply, State or lock change.
Merged as
9f0c84b95dc48330773125bbc7731077eb9cf379; exact tree matches reviewed head. Qualified Dev release 40898960690 started with runner_pool_size=1 and build_only=false; deployment and independent runtime verification are now successful (see final evidence below).Qualified Dev release 40898960690 succeeded on
9f0c84b95dc48330773125bbc7731077eb9cf379: 170/170 full model cases, 13/13 journey steps, build, artifact publication and deployment passed. Independent runtime verification confirmed the exact source, actual configured model identities, Assistant enabled and one live aligned runner-pool slot. Six historical source profiles and eight existing historical orders remain supported; prior recovery/follow-up Apply evidence remains intact. Route-free read-only diagnostic app was removed. No customer Plan, Apply, remote State or lock was changed.