Chore/stackittpr 739 change semver library - #1627
Conversation
- original implementation worked with KubernetesVersion and MachineImageVersion structs - from both types the version and state fields were used during version selection - introduced interface VersionWithState to cover both cases - introduce helper funcs for working with this interface: toVersionWithState, sortVersions, isDeprecated, isPreview, isSupported - consolidated getLatestSupportedMachineVersion and getLatestSupportedKubernetesVersion into getLatestSupportedVersion - test cases for these two functions were the same with the only difference being the type - consolidated TestGetLatestSupportedKubernetesVersion and TestGetLatestSupportedMachineVersion into TestGetLatestSupportedVersion - convert to VersionWithState early in call tree - extracted common parts into latestMatchingVersion - replace regex check for full version and selectFullVersion selectMatchingVersion with constraint and single selectVersion - move calculation of available out of selectVersion and into error branch, when no version could be found
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was closed automatically because it has been stalled for 7 days with no activity. Feel free to re-open it at any time. |
Description
I've used the mastermind semver library, since we already had it in our transitive deps
structs
selection
sortVersions, isDeprecated, isPreview, isSupported
getLatestSupportedKubernetesVersion into getLatestSupportedVersion
difference being the type
TestGetLatestSupportedMachineVersion into TestGetLatestSupportedVersion
selectMatchingVersion with constraint and single selectVersion
branch, when no version could be found
relates to #1234
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)