feat: add Gateway API ListenerSet template#576
Open
alex1989hu wants to merge 1 commit into
Open
Conversation
aslafy-z
requested changes
Jul 9, 2026
aslafy-z
left a comment
aslafy-z
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution
Please address this small nit before we can proceed.
| @@ -0,0 +1,22 @@ | |||
| {{- if and .Values.listenerSet .Values.listenerSet.enabled -}} | |||
| {{- if not (.Capabilities.APIVersions.Has "gateway.networking.k8s.io/v1") }} | |||
| {{- fail "There is no APIGateway resource definition in the target cluster!" }} | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| {{- fail "There is no APIGateway resource definition in the target cluster!" }} | |
| {{- fail "There is no Gateway API resource definitions in the target cluster!" }} |
Contributor
Author
There was a problem hiding this comment.
I used what we have in HTTPRoute to be consistent:
Shall I modify both resources?
Collaborator
There was a problem hiding this comment.
I'm wondering if a good move wouldn't be to add the full group in the error message rather than a arbitrary name. What do you think ?
Just update it for your resource for now, and we will open a follow-up pr - if you have time, we welcome prs 🙃
Contributor
Author
There was a problem hiding this comment.
Understood. I've pushed the requested change (+ unit test update) 4563f80
Adds a ListenerSet template so the chart can attach additional listeners to an existing Gateway, following the Gateway API ListenerSet resource. Closes stakater#547 Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
alex1989hu
force-pushed
the
feat-listenerset
branch
from
05806f3 to
4563f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ListenerSet template so the chart can attach additional listeners to an existing Gateway, following the Gateway API ListenerSet resource.
Closes #547