Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntryRepository::save()caches the entry under its URI:If the entry has no URI yet, the key is
eloquent-entry-, which is also whatfind(null)reads. Entries have no URI yet when they're new in a structured collection. After saving one,Entry::find(null)returns that entry for the rest of the request. Later entries saved without an id are treated as existing: noEntryCreatingorEntryCreatedevents, and noupdateEntryOrder()call.Propagated localizations run into this: in an orderable collection with two sites and propagation on, creating
din one site leaves the other site with the wrong order (dis new and propagates)This PR makes
find()returnnullfor empty ids without touching Blink, which matches the Stache.Similar fix in core: statamic/cms#15509.