Skip to content

feat: add stats/base/ndarray/dvariancetk - #14196

Open
Prathameshk2024 wants to merge 3 commits into
stdlib-js:developfrom
Prathameshk2024:routine/dvariancetk
Open

feat: add stats/base/ndarray/dvariancetk#14196
Prathameshk2024 wants to merge 3 commits into
stdlib-js:developfrom
Prathameshk2024:routine/dvariancetk

Conversation

@Prathameshk2024

@Prathameshk2024 Prathameshk2024 commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add stats/base/ndarray/dvariancetk

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@Prathameshk2024
Prathameshk2024 requested review from a team and a lite review from Copilot August 12, 2026 10:03
Copilot AI reviewed Aug 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@stdlib-bot

stdlib-bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Aug 12, 2026
@stdlib-bot

stdlib-bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

0PrashantYadav0
0PrashantYadav0 suggested changes Aug 13, 2026
View reviewed changes

@0PrashantYadav0 0PrashantYadav0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then some minor changes, everything LGTM!

Comment thread lib/node_modules/@stdlib/stats/base/ndarray/dvariancetk/examples/index.js Outdated
var ndarray2array = require( '@stdlib/ndarray/to-array' );
var dfirstIndexEqual = require( './../lib' );
var dvariancetk = require( '@stdlib/stats/base/ndarray/dvariancetk/lib' );

@0PrashantYadav0 0PrashantYadav0 Aug 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var dvariancetk = require( '@stdlib/stats/base/ndarray/dvariancetk/lib' );
var dvariancetk = require( './../lib' );

Comment thread lib/node_modules/@stdlib/stats/base/ndarray/dvariancetk/lib/index.js Outdated
*/

// MODULES //

var main = require( './main.js' );
var main = require( '@stdlib/stats/base/ndarray/dvariancetk/lib/main.js' );

@0PrashantYadav0 0PrashantYadav0 Aug 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var main = require( '@stdlib/stats/base/ndarray/dvariancetk/lib/main.js' );
var main = require( './main.js' );

Comment thread lib/node_modules/@stdlib/stats/base/ndarray/dvariancetk/test/test.js Outdated


// FUNCTIONS //

/**
* Returns a one-dimensional ndarray.
* Returns a one-dimensional ndarray .

@0PrashantYadav0 0PrashantYadav0 Aug 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Returns a one-dimensional ndarray .
* Returns a one-dimensional ndarray.

@0PrashantYadav0 0PrashantYadav0 added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 13, 2026
@0PrashantYadav0 0PrashantYadav0 removed the Needs Changes Pull request which needs changes before being merged. label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@0PrashantYadav0 0PrashantYadav0 0PrashantYadav0 approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Prathameshk2024 @stdlib-bot @0PrashantYadav0