test: migrate stats/base/dists/normal/mgf to ULP-based assertions - #14302
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VYbMUHCscinCpwPMnzDvH4 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/normal/mgffrom relative tolerance testing to ULP difference testing, as described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Changes are confined to
test/test.mgf.js,test/test.factory.js, andtest/test.native.js. In each fixture loop,var delta/var toland theabs( y - expected[i] ) <= EPS * abs( expected[i] )comparison are replaced witht.strictEqual( isAlmostSameValue( y, expected[ i ], N ), true, 'returns expected value' ), and the now-unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires are removed in favor of@stdlib/assert/is-almost-same-value. The existingexpected[i] !== nullguards are left in place.The ULP bounds were measured against the full fixture set (1000 cases per fixture) and tightened to the minimum passing integer:
positive_location.json1200.0 * EPS1867negative_location.json1050.0 * EPS2039large_variance.json700.0 * EPS969Each bound is the measured maximum ULP difference over its fixture, and is minimal: lowering any of them by one causes that fixture to fail (verified by running the suite at
N-1, which yields exactly one failure per fixture loop). The same bounds apply to all three test files, sincefactoryand the main export return identical values for every fixture case, and the C implementation mirrors the JavaScript implementation directly (exp( ( mu*t ) + ( 0.5 * pow( sigma*t, 2.0 ) ) )), so no JS vs. C divergence needed to be accounted for.The package test suite passes, and was run twice at the final ULP values to confirm the results are deterministic. ESLint (via
etc/eslint/.eslintrc.tests.js) is clean for the package.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
test/test.native.jswas skipped locally, as the native add-on was not built in the environment used to author this change; the bounds applied there are the ones measured against the JavaScript implementation. Please confirm CI exercises the native tests.Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, following the migration pattern established in previously merged conversions (e.g. #14274, #14272, #14267). The ULP bounds were determined empirically by measuring ULP differences across the full fixture set and verifying minimality, rather than guessed.
@stdlib-js/reviewers
Generated by Claude Code