bug fix for "_bmark_cache.npz file stores at program path"#19
Open
diphosphane wants to merge 1 commit into
Open
bug fix for "_bmark_cache.npz file stores at program path"#19diphosphane wants to merge 1 commit into
diphosphane wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_bmark_cache.npz file stores at program path will result several problem:
/usr/lib/python3.*/site-packages/sgdmlis not writable, which will results problem.In my fix, I modify the _bmark_cache.npz path into current task execution path, it would solve this bug.
I only test it in my task, I'm not sure whether this modification will introduce other bug or not.
Because this modification related with file path, I also checked the python code
os.chdir(which may conflict with my modification) , and not found the usage, so I think it may not introduce bug.