Finish xunit3 update with MTP - #13
Open
tebeco wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the test infrastructure to complete the xUnit v3 migration using Microsoft.Testing.Platform (MTP), including introducing a shared testing utility project and switching the test project to the MTP runner flow.
Changes:
- Added
Leda.Testingproject and moved/renamed shared test helpers into theLeda.Testingnamespace. - Updated
Leda.Testto run via MTP (exe output +UseMicrosoftTestingPlatformRunner) and switched toxunit.v3.mtp-v2. - Added
global.jsonto pin the .NET SDK and opt in to the Microsoft Testing Platform runner.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Scripts/GenerateResults.cs | Uses Leda.Testing for diagnostic output generation after helper namespace/project move. |
| Leda.Testing/Leda.Testing.csproj | New shared testing utilities project referenced by the test project. |
| Leda.Testing/DiagnosticPrinter.cs | Renames namespace to Leda.Testing for reuse from tests and scripts. |
| Leda.Test/Leda.Test.csproj | Switches test project to MTP runner + xunit.v3.mtp-v2 and references Leda.Testing. |
| Leda.Test/DiagnosticTest.cs | Updates imports and theory data row construction for xUnit v3 usage. |
| global.json | Pins SDK and opts dotnet test into Microsoft.Testing.Platform. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTP = Microsoft.Testing.Platform
MTP has been created ~1+ years ago to remove legacy dependency on VsTest (especially in console and runner)