Repository navigation
Conversation
Takes into account the script can be called many times, so the logfile has to be "ship"ed only once
Package version diff: none (aarch64-linux, x86_64-linux) |
Member
|
These failures are happening due to the
We will go through these in a call today. It can be tedious but clicking through the job failures will show you which commands failed (it is only a few because the other failures are due to skips or the initial failures) |
brainrake
requested changes
Nov 9, 2026
Co-authored-by: Márton Boros <martonboros@gmail.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Márton Boros <martonboros@gmail.com>
Co-authored-by: Márton Boros <martonboros@gmail.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Márton Boros <martonboros@gmail.com>
This comment has been minimized.
This comment has been minimized.
…ded!). prepare.sh : set back ship_log of $LOG_FILE to the proper place
brainrake
requested changes
Nov 10, 2026
brainrake
previously requested changes
Nov 10, 2026
Co-authored-by: Márton Boros <martonboros@gmail.com>
Co-authored-by: Márton Boros <martonboros@gmail.com>
jpargudo
dismissed
brainrake’s stale review
November 10, 2026 14:49
I did apply all of your last comments, that I did resolve, and applied to 2 patches.
Thank you !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
prepare.shandinitiate.sh:What is the current behavior?
prepare.shwas safe since it runs on a newly created VM, with no access except for us. But there was no logs and no "paranoid mode" on operations (stop PostgreSQL,umount /data, etc.)initiate.shWhat is the new behavior?
prepare.shhas been strongly hardened, probably in "paranoid mode".initiate.shnowNotes on pg_checksums
The part around enabling checksums is not meant to survive since in PostgreSQL will one day have checksums enabled on-line with
pg_enable_data_checksums()or removed the same way withpg_disable_data_checksums(). Unfortunately this feature was due for PG19, but has been removed from that version. We might then clean the code when PG20 is out, late 2027.