Repository navigation
Conversation
PostgreSQL Extension Dependency Analysis: PR #2639
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2639
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
Package version diff: none (aarch64-linux, x86_64-linux) |
Lets normalize smaller files and re-use. getkey-script's functionality is repeated a few times in the repo this is the first step to fixing that.
Doing this because bash in nix is pretty terrible to read, only ok-ish for small scripts which this is not. Also I'm going to be reworking some of this soonish and having shfmt, shellcheck while editing is super helpful. So create a directory and split the nix and bash to their own files. The seven values Nix interpolated into the script become @placeholders@ that default.nix substitutes. The final script is unchanged. Assisted-by: Claude <noreply@anthropic.com>
Split the migrate-and-dump half of dbmate-tool into this new package. dbmate-tool now uses this package and copies from $out to repo local directory. This will be used in a following commit as a nix check so we don't waste time building unnecessarily. Assisted-by: Claude <noreply@anthropic.com>
Take the version, port and store paths as positional arguments instead of substituting placeholders, and drop the option parsing, help text, dead flake-url handling, dump retries and pgrep cleanup, which a sandboxed build does not need. A trap stops the server. The dump is unchanged. Assisted-by: Claude <noreply@anthropic.com>
schema-check diffs the schema-dump output against the committed migrations/schema-<version>.sql. The schema-15, schema-17 and schema-orioledb-17 checks (x86_64-linux) replace the verify job, so they only rerun when the dump's inputs change. I've moved this into nix as it should have been from the beginning. nix can avoid unnecessary builds and/or tests and its easier to modify the nix-build.yml to tweak required checks. Having checks in nix also means we don't need to generate and maintain a bunch of yaml that does nothing on local dev machines. test.yml stays as a no-op so the required schema / verify (...) status checks keep reporting until the branch protection is updated. The adding-new-package doc no longer points at test.yml. Assisted-by: Claude <noreply@anthropic.com>
mmlb
force-pushed
the
mannymendez/mpg-75-improve-postgres-required-checks
branch
from
November 10, 2026 19:31
00540ba to
d30f024
Compare
mmlb
enabled auto-merge
November 11, 2026 03:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
The schmea verification happens as workflow job which means it usually runs unnecessarily, does not get run locally, requires bunch of yaml boiler plate and needs an owner to manage the PR required checkness of it.
What is the new behavior?
I've split the schema generation out of dbmate-tool into schema-dump.
I've added a new schema-check package that is wired up as a nix check.
CI will automatically run the check only when necessary.
CI is already setup so failed checks block PRs.