Add Windows pre-cleanup to CI workflows#161
Merged
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Windows CI workflows to proactively terminate stale processes before test environment setup, reducing interference from locked DLL/log files and leftover artifacts on self-hosted runners.
Changes:
- Added a Windows-only “init environment” pre-cleanup step to
new-framework-testbeforeprepare_test_env.py. - Replaced the prior targeted Python3 cleanup in
run-tests-on-windowswith a broadertaskkill-based cleanup across multiple TDengine-related executables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/run-tests-on-windows.yml |
Expands Windows pre-run cleanup from wmic-based python3-only termination to multi-image taskkill. |
.github/workflows/new-framework-test.yml |
Adds a Windows-only pre-cleanup step before environment preparation to reduce stale process interference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
feici02
approved these changes
May 8, 2026
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing