Skip to content

Add Windows pre-cleanup to CI workflows#161

Merged
feici02 merged 2 commits into
mainfrom
fix/windows-pre-cleanup
May 8, 2026
Merged

Add Windows pre-cleanup to CI workflows#161
feici02 merged 2 commits into
mainfrom
fix/windows-pre-cleanup

Conversation

@tomchon

@tomchon tomchon commented May 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a Windows-only init cleanup step to new-framework-test before prepare_test_env.py runs
  • replace the old single-process cleanup in run-tests-on-windows with a broader taskkill-based cleanup
  • reduce stale process interference with git clean, DLL usage, and leftover test artifacts

Testing

  • verified the workflow diffs locally
  • did not run the GitHub Actions workflows locally

Copilot AI review requested due to automatic review settings May 7, 2026 08:04
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Windows CI workflows to proactively terminate stale processes before test environment setup, reducing interference from locked DLL/log files and leftover artifacts on self-hosted runners.

Changes:

  • Added a Windows-only “init environment” pre-cleanup step to new-framework-test before prepare_test_env.py.
  • Replaced the prior targeted Python3 cleanup in run-tests-on-windows with a broader taskkill-based cleanup across multiple TDengine-related executables.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/run-tests-on-windows.yml Expands Windows pre-run cleanup from wmic-based python3-only termination to multi-image taskkill.
.github/workflows/new-framework-test.yml Adds a Windows-only pre-cleanup step before environment preparation to reduce stale process interference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/run-tests-on-windows.yml Outdated
Comment thread .github/workflows/run-tests-on-windows.yml Outdated
Comment thread .github/workflows/new-framework-test.yml Outdated
Comment thread .github/workflows/new-framework-test.yml Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@feici02

feici02 commented May 8, 2026

Copy link
Copy Markdown
Member

LGTM

@feici02 feici02 merged commit 2ba271b into main May 8, 2026
@feici02 feici02 deleted the fix/windows-pre-cleanup branch May 8, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants