audio: mixin_mixout: Correct underrun notification parameter#10995
Open
ujfalusi wants to merge 1 commit into
Open
audio: mixin_mixout: Correct underrun notification parameter#10995ujfalusi wants to merge 1 commit into
ujfalusi wants to merge 1 commit into
Conversation
The MIXER_UNDERRUN_DETECTED notification is initialized to carry the pipeline_id (SOF_IPC4_PIPELINE) as resource, not the module_id. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
abonislawski
approved these changes
Jul 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes the IPC4 SOF_IPC4_MIXER_UNDERRUN_DETECTED notification so that the notification’s resource_id correctly carries the pipeline ID (resource type SOF_IPC4_PIPELINE) instead of the mixin module’s component/instance ID.
Changes:
- Update the underrun notification call site to pass
dev->pipeline->pipeline_idas the notificationresource_id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MIXER_UNDERRUN_DETECTED notification is initialized to carry the pipeline_id (SOF_IPC4_PIPELINE) as resource, not the module_id.