ci: replace secrets: inherit with explicit secret forwarding#584
ci: replace secrets: inherit with explicit secret forwarding#584
Conversation
Each downstream release workflow now declares exactly which secrets it needs, and the parent release.yml passes only those. This reduces the blast radius if any single platform build is compromised — it can no longer access secrets belonging to other platforms.
Semgrep Security ScanNo security issues found. |
There was a problem hiding this comment.
cjroth has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
cjroth has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
PR Metrics
Updated Tue, 14 Apr 2026 21:40:59 GMT · run #807 |
|
Clean security improvement. Replacing |
|
LGTM — no issues found. |
Summary
secrets: inheritin release.yml with explicit per-platform secret declarationson.workflow_call.secretsblockGITHUB_TOKEN(automatic), so no secrets are forwarded to itTest plan
secrets:blocksNote
Medium Risk
Changes release pipeline secret scoping; main risk is misnamed/missing secrets causing release workflows to fail at runtime, but logic is otherwise straightforward.
Overview
Tightens secret exposure in the release pipeline by removing
secrets: inheritfromrelease.ymland explicitly forwarding only the per-platform secrets needed bydesktop-release.yml,ios-release.yml, andandroid-release.yml.Each called workflow now declares its required secrets under
on.workflow_call.secrets, so GitHub validates secret presence and prevents other platform jobs from accessing unrelated signing/upload credentials.Reviewed by Cursor Bugbot for commit 795b6d0. Bugbot is set up for automated code reviews on this repo. Configure here.