Skip to content

refactor: remove tinytools-std sanitizer dependency - #127

Merged
senamakel merged 4 commits into
tinyhumansai:mainfrom
senamakel:epic-8088-5-tinymcp-sanitize
Oct 19, 2026
Merged

senamakel merged 4 commits into
tinyhumansai:mainfrom
senamakel:epic-8088-5-tinymcp-sanitize

Conversation

@senamakel

@senamakel senamakel commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Tinymcp now uses tinytools::sanitize and drops its mandatory tinytools-std dependency. The sanitizer behavior and bus contract remain unchanged. The workspace moves to 0.20.0 because its public Rust tool APIs now expose TinyTools 0.6 types.

Refs senamakel#5. Part of tinyhumansai/openhuman#8088.

Validation:

  • Formatting and workspace all-target checks pass.
  • All-feature workspace Clippy passes with Rust/Clippy 1.99.0.
  • All-feature workspace tests: 1,718 passed, zero failed or ignored, including public-library, bus, and documentation tests.
  • The dependency tree resolves one TinyTools 0.6.0 source at reviewed commit 1ec3468f6602b69b955a0e94105ed63abb5aa98c; tinytools-std is absent.
  • Independent source review approved the complete four-file diff.

The host checkout's Rust 1.96.1 override cannot recognize two existing clippy::unused_async_trait_impl attributes in unchanged service.rs. Clippy 1.99 recognizes them and passes; the shared module CI selects stable. No lint suppression or service implementation change is included.

Release tracking remains open in senamakel#5: TinyTools version follow-up tinyhumansai/tinytools#77 must reach upstream before the module release. After the reviewed source lands, publish v0.20.0 through this module's tag-based release workflow, verify its archive checksums and compiler compatibility, then update OpenHuman's module registry and gitlink in a separate host PR. This PR does not publish artifacts or change the host pin.

Summary by CodeRabbit

  • Documentation
    • Updated sanitizer guidance to reflect the current source and Rust API path.
    • Clarified how package version information is set and validated during releases.

The sanitize helpers now live on tinytools itself, so the separate
tinytools-std dependency is no longer needed. This removes the crate and
its transitive dependencies from the lockfile.

Auto-committed-on: dragonfly
Updates the shared workspace version from 0.19.2 to 0.20.0 so all crates in the workspace move together for the next release.

Auto-committed-on: dragonfly
@tinysweeper

tinysweeper Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Incomplete
Priority: none
Reviewed head: f854726a8efc
Updated: 2026-10-19T16:50:47Z

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 0
Tests 0 Noted findings 0
Documentation 1 Resolved findings 0
Configuration 2 Pending checks/questions 4

Completeness: Incomplete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

  • Unreviewed: tinysweeper/tests

Findings

No active actionable findings.

Could not review: Cargo.toml, tinysweeper/description, tinysweeper/tests

Before merge

  • Complete the critique review for Cargo.toml.
  • Complete the security review for Cargo.toml.
  • Complete the tests review for tinysweeper/tests.
  • Complete the description review for tinysweeper/description.
Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: Cargo.toml
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: Cargo.toml.

security

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: Cargo.toml
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: Cargo.toml.

tests

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/tests
  • Lane summary: No reviewer produced a usable response.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/description
  • Lane summary: No reviewer produced a usable response.
Evidence and run details
  • Models: ladder/vectors-oai3
  • Spend: $0.000034
  • Tokens: 0 input · 0 output · 0 cached · 264 embedding
Head State Pass summary
76500dc46b57 incomplete 0 active finding(s), 0 resolved finding(s) (at 2026-10-18T21:21:05Z)
a8f4ea4e7403 incomplete 0 active finding(s), 0 resolved finding(s) (at 2026-10-18T21:32:43Z)
f854726a8efc incomplete 0 active finding(s), 0 resolved finding(s) (at 2026-10-19T16:50:47Z)

tinysweeper 0.1.2

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47e8fead-e24b-4a44-b034-acdb9e296bd7
📥 Commits

Reviewing files that changed from the base of the PR and between 6bc701a and f854726.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 4
  • Cargo.toml
  • crates/tinymcp/Cargo.toml
  • crates/tinymcp/src/sanitize/mod.rs
  • docs/specs/pure-vocabulary.md
+-------------------------------------------------------+
| Once upon a dream, I found all the bugs in your code. |
+-------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-19T16:50:13.592461Z f854726 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: Cargo.toml, crates/tinymcp/Cargo.toml, crates/tinymcp/src/sanitize/mod.rs, tinysweeper/description, tinysweeper/tests.

$0.0000 · 0 in / 0 out · 171 embedded · ladder/vectors-oai3

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/tinymcp/src/sanitize/mod.rs

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: docs/specs/pure-vocabulary.md, tinysweeper/description, tinysweeper/tests.

$0.0000 · 0 in / 0 out · 264 embedded · ladder/vectors-oai3

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@senamakel
senamakel merged commit 45e0301 into tinyhumansai:main Oct 19, 2026
1 check passed

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: Cargo.toml, tinysweeper/description, tinysweeper/tests.

$0.0000 · 0 in / 0 out · 264 embedded · ladder/vectors-oai3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant