-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(webapp,core,cli): filter runs by region in dashboard, API, and MCP #3612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericallam
wants to merge
1
commit into
feature/ai-chat-reference-and-cli
Choose a base branch
from
feat/runs-list-region-filter
base: feature/ai-chat-reference-and-cli
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "trigger.dev": patch | ||
| --- | ||
|
|
||
| MCP `list_runs` tool: add a `region` filter input and surface each run's executing region in the formatted summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@trigger.dev/core": patch | ||
| "@trigger.dev/sdk": patch | ||
| --- | ||
|
|
||
| Add `region` to the runs list / retrieve API: filter runs by region (`runs.list({ region: "..." })` / `filter[region]=<masterQueue>`) and read each run's executing region from the new `region` field on the response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { FlagIcon } from "~/assets/icons/RegionIcons"; | ||
| import { cn } from "~/utils/cn"; | ||
|
|
||
| type RegionLabelProps = { | ||
| region: { | ||
| name: string; | ||
| location?: string | null; | ||
| }; | ||
| className?: string; | ||
| iconClassName?: string; | ||
| }; | ||
|
|
||
| export function RegionLabel({ region, className, iconClassName }: RegionLabelProps) { | ||
| return ( | ||
| <span className={cn("flex items-center gap-1", className)}> | ||
| {region.location ? ( | ||
| <FlagIcon region={region.location} className={cn("size-5", iconClassName)} /> | ||
| ) : null} | ||
| {region.name} | ||
| </span> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Missing
regionsinhasFilterscheck prevents "Clear all filters" button from appearingThe
hasFiltersvariable inRunsFilters(apps/webapp/app/components/runs/v3/RunFilters.tsx:377-389) determines whether the "Clear all filters" button is shown. The PR addedregionsas a new filter type throughout the codebase (filter menu, applied filter pill, search params parsing, ClickHouse query, etc.) but did not addsearchParams.has("regions")to this check. When a user applies only a region filter, the "Clear all filters" button will not appear, leaving the user without a quick way to reset filters.(Refers to lines 377-389)
Was this helpful? React with 👍 or 👎 to provide feedback.