fix(webapp): fetch run-scoped trace subtrees for large traces#4024
fix(webapp): fetch run-scoped trace subtrees for large traces#4024kathiekiwi wants to merge 1 commit into
Conversation
|
WalkthroughThe PR switches trace retrieval to run-scoped subtrees for large traces, adds truncation and missing-anchor flags to trace data, updates the presenter and UI to show a warning when the trace is partial, changes the retrieve-trace API to use subtree retrieval, and updates invite acceptance to provision development environments with new form-level error handling. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
fix/trace-view-for-large-runs
branch
from
4b682e8 to
5986c3b
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/webapp/app/v3/taskEventStore.server.ts (1)
103-141: 🚀 Performance & Scalability | 🟡 MinorMissing compound index on
TaskEventPartitionedfor unboundedtraceIdlookups whenskipTimeWindowis enabled.When
skipTimeWindowis true, thecreatedAtrange predicate is dropped (line 107), removing partition pruning. The query is then bounded only bytraceIdandtake: options?.limit. The current indexes onTaskEventPartitioned(single-column ontraceId,spanId,runId) will result in scanning multiple index entries before the limit is applied.This design is intentional for subtree queries (ancestors/descendants can fall outside the anchor window), and usage is correctly restricted to that path in
eventRepository.server.ts. However, adding a compound index on(traceId, createdAt)or(traceId, spanId)would improve performance for these unbounded scans.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f72cd7f6-5f2c-44af-a765-b201113f2861
📒 Files selected for processing (12)
.server-changes/trace-view-large-runs-subtree.mdapps/webapp/app/presenters/v3/RunPresenter.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsxapps/webapp/app/routes/api.v1.runs.$runId.trace.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/app/v3/eventRepository/eventRepository.types.tsapps/webapp/app/v3/mollifier/syntheticTrace.server.tsapps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsdocs/management/runs/retrieve-trace.mdxdocs/v3-openapi.yaml
✅ Files skipped from review due to trivial changes (1)
- docs/management/runs/retrieve-trace.mdx
🚧 Files skipped from review as they are similar to previous changes (7)
- apps/webapp/app/v3/mollifier/syntheticTrace.server.ts
- docs/v3-openapi.yaml
- apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx
- apps/webapp/app/routes/api.v1.runs.$runId.trace.ts
- apps/webapp/app/presenters/v3/RunPresenter.server.ts
- apps/webapp/app/v3/eventRepository/eventRepository.server.ts
- apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (13)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: 🛡️ E2E Auth Tests (full)
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects insteadImport from
@trigger.dev/sdkwhen writing Trigger.dev tasks. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob
Files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only frompackages/core(@trigger.dev/core), never import from the root
Files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathUse named constants for sentinel/placeholder values (e.g.
const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons
Files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
apps/webapp/**/*.server.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/**/*.server.ts: Never userequest.signalfor detecting client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.tsinstead, which is wired directly to Expressres.on('close')and fires reliably
Access environment variables viaenvexport fromapp/env.server.ts. Never useprocess.envdirectly
Always usefindFirstinstead offindUniquein Prisma queries.findUniquehas an implicit DataLoader that batches concurrent calls and has active bugs even in Prisma 6.x (uppercase UUIDs returning null, composite key SQL correctness issues, 5-10x worse performance).findFirstis never batched and avoids this entire class of issues
Files:
apps/webapp/app/v3/taskEventStore.server.ts
**/*.{js,ts,tsx,jsx,css,json,md}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier for code formatting and run
pnpm run formatbefore committing
Files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testableFor testable code, never import
env.server.tsin test files. Pass configuration as options instead (e.g.,realtimeClient.server.tstakes config as constructor arg,realtimeClientGlobal.server.tscreates singleton with env config)
Files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.test.{ts,tsx}: Never mock anything in tests - use testcontainers instead
Test files should be placed next to source files (e.g.,MyService.ts->MyService.test.ts)
Files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
**/*.test.{js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.test.{js,ts,tsx}: Test files should live beside the files under test and use descriptivedescribeanditblocks
Use vitest for unit testing
Tests should avoid mocks or stubs and use helpers from@internal/testcontainerswhen Redis or Postgres are needed
Files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
🧠 Learnings (19)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/taskEventStore.server.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/v3/taskEventStore.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/app/v3/eventRepository/eventRepository.types.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
📚 Learning: 2026-05-14T14:54:39.095Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.
Applied to files:
.server-changes/trace-view-large-runs-subtree.md
🪛 LanguageTool
.server-changes/trace-view-large-runs-subtree.md
[style] ~6-~6: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...race views for child and nested runs in very large traces. The dashboard and retrieve-trac...
(EN_WEAK_ADJECTIVE)
🔇 Additional comments (4)
.server-changes/trace-view-large-runs-subtree.md (1)
1-7: LGTM!apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts (1)
1-304: LGTM!apps/webapp/app/v3/eventRepository/eventRepository.types.ts (1)
311-312: LGTM!Also applies to: 356-357, 423-433, 443-453
apps/webapp/app/v3/taskEventStore.server.ts (1)
59-62: LGTM!Also applies to: 103-107
kathiekiwi
force-pushed
the
fix/trace-view-for-large-runs
branch
from
5986c3b to
be385f1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
fix/trace-view-for-large-runs
branch
2 times, most recently
from
fbd7233 to
840877f
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
fix/trace-view-for-large-runs
branch
from
840877f to
92087e6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
fix/trace-view-for-large-runs
branch
from
92087e6 to
c9d82a7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Large traces capped by row limits could leave child runs with an empty trace view when their span fell outside the first time-ordered slice. Fetch the anchor span subtree for the dashboard and trace API, surface truncation in the UI, and document the run-scoped response shape.
kathiekiwi
force-pushed
the
fix/trace-view-for-large-runs
branch
from
c9d82a7 to
fe08282
Compare
| } catch (error) { | ||
| if (isAcceptInviteFormError(error)) { | ||
| return json( | ||
| { | ||
| intent: submission.intent, | ||
| payload: submission.payload, | ||
| error: { __form__: [error.message] }, | ||
| }, | ||
| { status: 400 } | ||
| ); | ||
| } | ||
| throw error; |
There was a problem hiding this comment.
🟡 Declining an already-consumed invite now crashes with a 500 error instead of showing a user-friendly message
Errors from the decline-invite path are no longer caught (throw error at apps/webapp/app/routes/invites.tsx:100) because the new catch block only handles accept-specific error types, so a Prisma "record not found" error surfaces as a server error page.
Impact: Users who click "Decline" on an invite that was already accepted or revoked by someone else see a crash page instead of a graceful error.
Mechanism: narrowed catch block excludes decline errors
The try block at apps/webapp/app/routes/invites.tsx:54-88 covers both the accept and decline branches. Previously (left side line 83), all errors were caught and returned as a 400 JSON response:
catch (error: any) {
return json({ errors: { body: error.message } }, { status: 400 });
}
The new code (right side lines 89-100) only catches errors matching isAcceptInviteFormError, which checks for INVITE_NOT_FOUND or ENV_SETUP_INCOMPLETE messages (apps/webapp/app/models/member.server.ts:13-18).
The declineInvite function (apps/webapp/app/models/member.server.ts:378-406) calls prisma.orgMemberInvite.delete(...) inside a transaction. If the invite was already consumed, Prisma throws a PrismaClientKnownRequestError with code P2025. This error is NOT an instance of Error with one of the two expected messages, so isAcceptInviteFormError returns false and the error is re-thrown, causing a 500/error boundary instead of a 400.
Prompt for agents
The catch block in the invites route action (apps/webapp/app/routes/invites.tsx, lines 89-100) now only handles errors matching isAcceptInviteFormError (INVITE_NOT_FOUND or ENV_SETUP_INCOMPLETE). However, the try block covers both the accept AND decline branches. The declineInvite function can throw PrismaClientKnownRequestError (code P2025) if the invite was already deleted, and this error is no longer caught gracefully.
Possible fixes:
1. Add handling for Prisma P2025 errors in the catch block (returning a user-friendly message like "This invite is no longer available")
2. Add a separate try/catch around the declineInvite call
3. Change declineInvite to use findFirst + delete pattern (like acceptInvite now does) to avoid throwing on missing records
Was this helpful? React with 👍 or 👎 to provide feedback.
| export async function acceptInvite({ | ||
| user, | ||
| inviteId, | ||
| }: { | ||
| user: { id: string; email: string }; | ||
| inviteId: string; | ||
| }) { | ||
| const invite = await prisma.orgMemberInvite.findFirst({ | ||
| where: { id: inviteId, email: user.email }, | ||
| include: { | ||
| organization: { | ||
| include: { | ||
| projects: { where: { deletedAt: null } }, | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
| if (!invite) { | ||
| throw new Error(INVITE_NOT_FOUND); | ||
| } | ||
|
|
||
| let member = await prisma.orgMember.findFirst({ | ||
| where: { userId: user.id, organizationId: invite.organizationId }, | ||
| }); | ||
| if (!member) { | ||
| try { | ||
| member = await prisma.orgMember.create({ | ||
| data: { | ||
| organizationId: invite.organizationId, | ||
| userId: user.id, | ||
| role: invite.role, | ||
| }, | ||
| }); | ||
| } catch (error) { | ||
| if ( | ||
| error instanceof PrismaNamespace.PrismaClientKnownRequestError && | ||
| error.code === "P2002" | ||
| ) { | ||
| member = await prisma.orgMember.findFirst({ | ||
| where: { userId: user.id, organizationId: invite.organizationId }, | ||
| }); | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (!member) { | ||
| throw new Error(ENV_SETUP_INCOMPLETE); | ||
| } | ||
|
|
||
| await provisionMemberDevelopmentEnvironments({ | ||
| inviteId, | ||
| user, | ||
| member, | ||
| organization: invite.organization, | ||
| projects: invite.organization.projects, | ||
| }); | ||
|
|
||
| try { | ||
| await prisma.orgMemberInvite.delete({ | ||
| where: { | ||
| id: inviteId, | ||
| email: user.email, | ||
| }, | ||
| }); | ||
| } catch (error) { | ||
| if (error instanceof PrismaNamespace.PrismaClientKnownRequestError && error.code === "P2025") { | ||
| // Another concurrent accept finished first — membership and envs are ready. | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
🚩 acceptInvite no longer uses a transaction — concurrent accepts could create duplicate environments
The old acceptInvite wrapped all operations (invite deletion, member creation, environment creation) in a single prisma.$transaction. The new code (apps/webapp/app/models/member.server.ts:262-375) performs these as separate, non-transactional operations. While it handles the member-creation race via P2002 catch, two concurrent acceptInvite calls could both pass the provisionMemberDevelopmentEnvironments check (since existingDevEnvs is read before creation) and attempt to create the same environment. The createEnvironment function creates a runtimeEnvironment record — if there's no unique constraint on (orgMemberId, projectId, type), this could result in duplicate dev environments. If there IS a unique constraint, the second call would throw inside the for-loop and return ENV_SETUP_INCOMPLETE despite the first call having succeeded. The idempotency check at apps/webapp/app/models/member.server.ts:206-215 mitigates this on retry.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4fc0c4c9-873b-4382-8fac-457e5875d4ef
📒 Files selected for processing (15)
.server-changes/fetch-ancestors-outside-anchor-window.md.server-changes/trace-view-large-runs-subtree.mdapps/webapp/app/models/member.server.tsapps/webapp/app/presenters/v3/RunPresenter.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsxapps/webapp/app/routes/api.v1.runs.$runId.trace.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/app/v3/eventRepository/eventRepository.types.tsapps/webapp/app/v3/mollifier/syntheticTrace.server.tsapps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.tsapps/webapp/test/member.server.test.tsdocs/management/runs/retrieve-trace.mdxdocs/v3-openapi.yaml
✅ Files skipped from review due to trivial changes (3)
- .server-changes/fetch-ancestors-outside-anchor-window.md
- docs/management/runs/retrieve-trace.mdx
- docs/v3-openapi.yaml
🚧 Files skipped from review as they are similar to previous changes (8)
- apps/webapp/app/routes/api.v1.runs.$runId.trace.ts
- apps/webapp/app/v3/mollifier/syntheticTrace.server.ts
- apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx
- apps/webapp/test/getTraceDetailedSubtreeSummary.integration.test.ts
- apps/webapp/app/v3/eventRepository/eventRepository.types.ts
- apps/webapp/app/presenters/v3/RunPresenter.server.ts
- apps/webapp/app/v3/eventRepository/eventRepository.server.ts
- apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (13)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: 🛡️ E2E Auth Tests (full)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects insteadImport from
@trigger.dev/sdkwhen writing Trigger.dev tasks. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob
Files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only frompackages/core(@trigger.dev/core), never import from the root
Files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
apps/webapp/test/member.server.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/test/member.server.test.tsapps/webapp/app/models/member.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathUse named constants for sentinel/placeholder values (e.g.
const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons
Files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testableFor testable code, never import
env.server.tsin test files. Pass configuration as options instead (e.g.,realtimeClient.server.tstakes config as constructor arg,realtimeClientGlobal.server.tscreates singleton with env config)
Files:
apps/webapp/test/member.server.test.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.test.{ts,tsx}: Never mock anything in tests - use testcontainers instead
Test files should be placed next to source files (e.g.,MyService.ts->MyService.test.ts)
Files:
apps/webapp/test/member.server.test.ts
**/*.{js,ts,tsx,jsx,css,json,md}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier for code formatting and run
pnpm run formatbefore committing
Files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
**/*.test.{js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.test.{js,ts,tsx}: Test files should live beside the files under test and use descriptivedescribeanditblocks
Use vitest for unit testing
Tests should avoid mocks or stubs and use helpers from@internal/testcontainerswhen Redis or Postgres are needed
Files:
apps/webapp/test/member.server.test.ts
apps/webapp/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Only use
useCallback/useMemofor context provider values, expensive derived data that is a dependency elsewhere, or stable refs required by a dependency array. Don't wrap ordinary event handlers or trivial computations
Files:
apps/webapp/app/routes/invites.tsx
apps/webapp/**/*.server.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/**/*.server.ts: Never userequest.signalfor detecting client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.tsinstead, which is wired directly to Expressres.on('close')and fires reliably
Access environment variables viaenvexport fromapp/env.server.ts. Never useprocess.envdirectly
Always usefindFirstinstead offindUniquein Prisma queries.findUniquehas an implicit DataLoader that batches concurrent calls and has active bugs even in Prisma 6.x (uppercase UUIDs returning null, composite key SQL correctness issues, 5-10x worse performance).findFirstis never batched and avoids this entire class of issues
Files:
apps/webapp/app/models/member.server.ts
🧠 Learnings (22)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/member.server.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/member.server.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/routes/invites.tsxapps/webapp/app/models/member.server.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/member.server.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/models/member.server.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/test/member.server.test.tsapps/webapp/app/models/member.server.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/test/member.server.test.ts
📚 Learning: 2026-02-03T18:27:40.429Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 2994
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx:553-555
Timestamp: 2026-02-03T18:27:40.429Z
Learning: In apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx, the menu buttons (e.g., Edit with PencilSquareIcon) in the TableCellMenu are intentionally icon-only with no text labels as a compact UI pattern. This is a deliberate design choice for this route; preserve the icon-only behavior for consistency in this file.
Applied to files:
apps/webapp/app/routes/invites.tsx
📚 Learning: 2026-02-11T16:37:32.429Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3019
File: apps/webapp/app/components/primitives/charts/Card.tsx:26-30
Timestamp: 2026-02-11T16:37:32.429Z
Learning: In projects using react-grid-layout, avoid relying on drag-handle class to imply draggability. Ensure drag-handle elements only affect dragging when the parent grid item is configured draggable in the layout; conditionally apply cursor styles based on the draggable prop. This improves correctness and accessibility.
Applied to files:
apps/webapp/app/routes/invites.tsx
📚 Learning: 2026-05-08T21:00:20.973Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3538
File: apps/webapp/app/components/primitives/Resizable.tsx:60-78
Timestamp: 2026-05-08T21:00:20.973Z
Learning: In the triggerdotdev/trigger.dev codebase, treat Zod as a boundary validation tool (API handlers, request/response validation, and storage/DB read/write validation), not as inline render-time validation inside React components/primitive UI code. For render-time guards, prefer small manual type-narrowing checks (e.g., a short predicate like ~10–20 lines) over importing Zod into UI primitives, to avoid per-render schema-parse overhead and unnecessary abstraction. Use the manual guard approach unless you truly need schema validation at a boundary; only then introduce Zod.
Applied to files:
apps/webapp/app/routes/invites.tsx
📚 Learning: 2026-06-25T18:21:55.847Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-resend.tsx:0-0
Timestamp: 2026-06-25T18:21:55.847Z
Learning: In the triggerdotdev/trigger.dev Zod 4 migration, avoid importing from the root package `conform-to/zod` in webapp code. It can resolve to the Zod 3 build and may crash at module load under Zod 4. When reviewing TypeScript/TSX files in `apps/webapp`, prefer importing from the Zod 4 subpath `conform-to/zod/v4` for Zod 4-compatible schemas/types.
Applied to files:
apps/webapp/app/routes/invites.tsx
📚 Learning: 2026-06-25T18:21:54.729Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/confirm-basic-details.tsx:0-0
Timestamp: 2026-06-25T18:21:54.729Z
Learning: For Remix + TypeScript files that use Conform v1 (conform-to/react) and its getInputProps helper, when you intend to suppress the helper-provided default value for non-checkbox/non-radio inputs (e.g., hidden inputs managed via an explicit value prop), use the Conform v1 option key `value: false`. Do not recommend `defaultValue: false` here, because `defaultValue` is not a valid option key for these input types in Conform v1 typings.
Applied to files:
apps/webapp/app/routes/invites.tsx
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/models/member.server.ts
📚 Learning: 2026-05-14T14:54:39.095Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.
Applied to files:
.server-changes/trace-view-large-runs-subtree.md
🪛 LanguageTool
.server-changes/trace-view-large-runs-subtree.md
[style] ~6-~6: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...race views for child and nested runs in very large traces. The dashboard and retrieve-trac...
(EN_WEAK_ADJECTIVE)
🔇 Additional comments (5)
.server-changes/trace-view-large-runs-subtree.md (1)
1-7: LGTM!apps/webapp/app/models/member.server.ts (2)
8-17: LGTM!
269-375: LGTM!apps/webapp/app/routes/invites.tsx (1)
15-21: LGTM!Also applies to: 89-100, 130-130
apps/webapp/test/member.server.test.ts (1)
1-13: LGTM!Also applies to: 30-318
| const existingDevEnvs = await prisma.runtimeEnvironment.findMany({ | ||
| where: { | ||
| orgMemberId: member.id, | ||
| type: "DEVELOPMENT", | ||
| projectId: { in: projectIds }, | ||
| }, | ||
| select: { projectId: true }, | ||
| }); | ||
| const existingProjectIds = new Set(existingDevEnvs.map((env) => env.projectId)); | ||
| const projectsToProvision = projects.filter((project) => !existingProjectIds.has(project.id)); | ||
|
|
||
| // 2. Join the organization | ||
| const member = await tx.orgMember.create({ | ||
| data: { | ||
| organizationId: invite.organizationId, | ||
| userId: user.id, | ||
| role: invite.role, | ||
| }, | ||
| }); | ||
| const createdProjectIds: string[] = []; | ||
| let failedProjectId: string | undefined; | ||
| let failedProjectIndex: number | undefined; | ||
|
|
||
| try { | ||
| for (const [index, project] of projectsToProvision.entries()) { | ||
| failedProjectId = project.id; | ||
| failedProjectIndex = index; | ||
|
|
||
| // 3. Create an environment for each project | ||
| for (const project of invite.organization.projects) { | ||
| await createEnvironment({ | ||
| organization: invite.organization, | ||
| organization, | ||
| project, | ||
| type: "DEVELOPMENT", | ||
| // We set this true but no backfill (yet!?) so never used | ||
| // for dev environments | ||
| isBranchableEnvironment: true, | ||
| member, | ||
| prismaClient: tx, | ||
| }); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make duplicate dev-env creation idempotent under concurrent accepts.
Two concurrent acceptInvite calls can both see the same project as missing, then one createEnvironment succeeds and the other hits the runtime-environment unique constraint for the same member/project. That second request currently throws ENV_SETUP_INCOMPLETE even though the other request may have completed setup. Treat Prisma P2002 for the per-project env create as “already created” by re-checking that project/member env and continuing.
| vi.mock("~/db.server", () => ({ | ||
| get prisma() { | ||
| if (!prismaHolder.client) { | ||
| throw new Error("test prisma not set"); | ||
| } | ||
| return prismaHolder.client; | ||
| }, | ||
| get $replica() { | ||
| if (!prismaHolder.client) { | ||
| throw new Error("test prisma not set"); | ||
| } | ||
| return prismaHolder.client; | ||
| }, | ||
| })); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the model's runtime import and the test mock's exported members.
rg -n -C2 'Prisma as PrismaNamespace|from "~/db\.server"' apps/webapp/app/models/member.server.ts
sed -n '15,28p' apps/webapp/test/member.server.test.tsRepository: triggerdotdev/trigger.dev
Length of output: 743
Missing Prisma namespace export in ~/db.server mock
The test mock in apps/webapp/test/member.server.test.ts fails to export the Prisma namespace, which is explicitly imported in apps/webapp/app/models/member.server.ts (line 2). Without this export, any runtime access to Prisma.PrismaClientKnownRequestError or similar type guards will throw Cannot read properties of undefined.
Update the mock to include the Prisma namespace:
Proposed fix
vi.mock("~/db.server", async () => {
+ const { Prisma } = await vi.importActual<typeof import("`@trigger.dev/database`")>(
+ "`@trigger.dev/database`"
+ );
return {
+ Prisma,
get prisma() {
if (!prismaHolder.client) {
throw new Error("test prisma not set");
}
return prismaHolder.client;
},
// ... existing code
};
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| vi.mock("~/db.server", () => ({ | |
| get prisma() { | |
| if (!prismaHolder.client) { | |
| throw new Error("test prisma not set"); | |
| } | |
| return prismaHolder.client; | |
| }, | |
| get $replica() { | |
| if (!prismaHolder.client) { | |
| throw new Error("test prisma not set"); | |
| } | |
| return prismaHolder.client; | |
| }, | |
| })); | |
| vi.mock("~/db.server", async () => { | |
| const { Prisma } = await vi.importActual<typeof import("`@trigger.dev/database`")>( | |
| "`@trigger.dev/database`" | |
| ); | |
| return { | |
| Prisma, | |
| get prisma() { | |
| if (!prismaHolder.client) { | |
| throw new Error("test prisma not set"); | |
| } | |
| return prismaHolder.client; | |
| }, | |
| get $replica() { | |
| if (!prismaHolder.client) { | |
| throw new Error("test prisma not set"); | |
| } | |
| return prismaHolder.client; | |
| }, | |
| }; | |
| }); |
1 participant
Summary
Large traces are loaded using a capped, time-ordered query. For child or nested runs, the run's span could fall outside that initial slice, causing the trace view to render empty.
This PR adds run-scoped subtree loading when the requested run span is not present in the initial trace results and applies the same behavior to the trace API.
Changes
Dashboard
Falls back to run-scoped subtree loading when the requested run span is missing from the initial trace results
Shows a warning when the trace is truncated or cannot be fully resolved
Trace API (GET /api/v1/runs/:runId/trace)
Returns a trace rooted at the requested run's span
Fixes incomplete or empty traces for child and nested runs in large traces
Event repositories
Run-scoped subtree retrieval is ClickHouse-only; Postgres re-roots the existing full-trace summary in memory (no new queries).
Docs
Updated API and trace documentation to reflect run-scoped trace behavior
Testing
Changelog
Fixed trace rendering for child and nested runs in large traces. Dashboard and trace API responses now load the requested run's trace subtree instead of depending on the run span appearing in the initial trace slice.