Statically import libsql targets#89
Closed
msanchezdev wants to merge 1 commit intotursodatabase:mainfrom
Closed
Conversation
Contributor
|
Oh, nice @msanchezdev! Does it mean we can drop the |
Author
|
@penberg I wasn't sure about neon, have to check how it works, but I am trying another approach now as this way it actually seems to be bundling all into the binary |
LucioFranco
approved these changes
Mar 11, 2024
giovannibenussi
approved these changes
Apr 30, 2024
Contributor
|
Hey, there are any updates regarding this? It would be nice to drop the |
penberg
force-pushed
the
main
branch
3 times, most recently
from
3dd2f0a to
4a3f0cc
Compare
Contributor
|
Obsoleted by #182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if there are more targets, but developing with bun using the single-file executable mode the libsql driver fails to be imported from the embedded file system as Bun doesn't detect what files are to be imported if done dynamically.
As the code dynamically imports the proper target module we can get a false positive if the built file is run in a project that has the
node_modules/@libsql/*target folders so it's recommended to test this by copying the binary file to another directory or simply running it from somewhere else:e.g:
Image Error Transcript: