Fix invalid state in transaction#2009
Merged
penberg merged 2 commits intotursodatabase:mainfrom Apr 1, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2004.
The gRPC code gets the
Statusinformation from the server to know if a transaction was successful. Now, every time we try to run a statement, theis_autocommitis run on the remote connection to know if we are in aState::Txnor not.After that, the code is basically a copy of
crate::replication::connection::should_execute_localwith the addition that when matching if the code should execute locally, thestateis set to thepredicted_end_state. This step was skipped by the old implementation because after a remote statement statement executed, the end state came from the server as mentioned before.stateis mostly concerned to know if the server is in a transaction and that we should keep sending remote queries until aCOMMITorROLLBACK. The match statement could be refactored to reflect this more clearly.