Attempt to bootstrap the db on connect#2029
Merged
penberg merged 2 commits intotursodatabase:mainfrom Apr 11, 2025
Merged
Conversation
avinassh
changed the title
connectconnect
aminya
reviewed
Aug 1, 2025
| }; | ||
| use tokio::sync::Mutex; | ||
|
|
||
| let _ = tokio::task::block_in_place(move || { |
There was a problem hiding this comment.
This breaks Db initialization under Actix due to its blocking nature. It forces the user to separate the db initialization out of the actix main and create a custom main which initializes the db first in a multi-threaded Tokio runtime and then passes it to Actix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2024
Whenever
db.connectis called, we will try to bootstrap the db if required