Fix Connection::changes() for remote queries#2044
Merged
penberg merged 2 commits intotursodatabase:mainfrom May 6, 2025
Merged
Fix Connection::changes() for remote queries#2044penberg merged 2 commits intotursodatabase:mainfrom
penberg merged 2 commits intotursodatabase:mainfrom
Conversation
penberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation is very much not ideal and should be reworked.
Its exposing the
Innetype andinnerparameter ofHranaStream. I can't think of a way to structure the code in a better way, but later we could extend the protocol to include the changes made by the query as a initial response, preventing having to hold a reference the the stream all together.