Skip to content

Fix: fix osx cp warning. #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penberg merged 1 commit into from
Jun 26, 2025
+6 −2
Merged

Fix: fix osx cp warning. #2103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libsql-ffi/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,12 @@ fn copy_dir_all(src: impl AsRef<Path>, dst: impl AsRef<Path>) -> io::Result<()>
/// propagate into OUT_DIR. If not present, when trying to rewrite a file, a `Permission denied`
/// error will occur.
fn copy_with_cp(from: impl AsRef<Path>, to: impl AsRef<Path>) -> io::Result<()> {
match Command::new("cp")
.arg("--no-preserve=mode,ownership")
let mut command = Command::new("cp");
// --no-preserve is enabled by default on macos
// preserve must be explicitly enabled with the -p flag
#[cfg(not(target_os = "macos"))]
let command = command.arg("--no-preserve=mode,ownership");
match command
.arg("-R")
.arg(from.as_ref().to_str().unwrap())
.arg(to.as_ref().to_str().unwrap())
Expand Down
Loading