Conversation
- someone was drunk when these methods was added 🍻
levydsa
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, right now, embedded replica will fail if WAL reached size of more than
4120frame (familiar number, huh?).The issue is that in the Rust API we pass
frame.len()as aframe_noand 0 as aframe.len()🤪The failure happens because
wal_insertC code will check frame for conflict in case whenif (iFrame <= mxFrame)and then try to allocatenBuf - 24bytes (wherenBufequals to0due to bug)This PR fixes this bug and also added simple test to check the API.