Fix durable frame tracking to follow transaction boundaries#2129
Merged
Fix durable frame tracking to follow transaction boundaries#2129
Conversation
penberg
changed the title
penberg
approved these changes
Jul 15, 2025
avinassh
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull logic used invalid property of WAL in its implementation and was written under assumption that any frames written to WAL are durable.
This is not true in case of frames written for unfinished transaction, because such frames will be omitted by any SQLite connection except from the one which created them. So, in case of restart - we will "loose" these frames, but
durable_frame_numwill incorrectly state that we already written "missed" portion of WAL.This PR fix this issue and make pull to persist information about "durable_frame_num" only at transaction boundaries.