Repository navigation
Conversation
|
Just asking. Can we also create a pull request template? I think that is a good place to act as a reminder... and it's also a sign of LLM agents... which most of the time are ignoring the template... so it's a sign that the PR ls LLM generated. |
Excellent question and aligns with something Glyph said yesterday. (I'm doing this to a bunch of repos & have a spreadsheet going; reach out if you'd like to claim some repos to apply this treatment to with us.) Trying to get a good generic & basic list that will not need much editing across a large number of repos is slightly challenging; if you have ideas about that please share! |
(copied wholesale from the Twisted main repository)
| Please create one if missing. | ||
| Someone from the core team will probably do this for you, but your review might go a bit faster if you do it yourself. | ||
| * [ ] The title of the PR should describe the changes and starts with the associated issue number, like `#1234 Brief description`. | ||
| * [ ] A release notes news fragment file was create in src/incremental/newsfragments/ (see: [Release notes fragments docs.](https://docs.twisted.org/en/latest/development/dev-process.html)) |
There was a problem hiding this comment.
highlighting this in the diff as the only line I tweaked from Twisted's PR template
adiroiban
left a comment
adiroiban
left a comment
There was a problem hiding this comment.
Thanks. I think that this is much better than what we have now.
I will not merge this myself. I will leave for one of the active maintainers for incremntal to decide if this should be merged.
Thanks again!
twm
left a comment
twm
left a comment
There was a problem hiding this comment.
Thank you for the PR! Before we can merge, could you address the issues I noted inline? Thanks!
| * [ ] The title of the PR should describe the changes and starts with the associated issue number, like `#1234 Brief description`. | ||
| * [ ] A release notes news fragment file was create in src/incremental/newsfragments/ (see: [Release notes fragments docs.](https://docs.twisted.org/en/latest/development/dev-process.html)) | ||
| * [ ] The automated tests were updated. | ||
| * [ ] Once all checks are green, request a review by leaving a comment that contains exactly the string `please review`. |
There was a problem hiding this comment.
This repo isn't set up with the review bot, so:
| * [ ] Once all checks are green, request a review by leaving a comment that contains exactly the string `please review`. |
| Our bot will trigger the review process, by applying the pending review label | ||
| and requesting a review from the Twisted dev team. |
There was a problem hiding this comment.
Same rationale:
| Our bot will trigger the review process, by applying the pending review label | |
| and requesting a review from the Twisted dev team. |
| AI Policy | ||
| --------- | ||
|
|
||
| This repository does not allow the inclusion of the outputs of generative AI tools, following the `Twisted AI Policy <https://docs.twisted.org/en/latest/development/ai-policy.html>`_. |
There was a problem hiding this comment.
Please move this to the end of the file, rather than interrupting the flow of the narrative documentation.
From discussion on the fediverse