Implement constructor generic pre-binding and enhance runtime type ch… - #73
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Notes
Overview
TypePHP now eagerly binds generic template contracts to class instances before
__constructparameter validation executes when an inline/** @var ClassName<Type> */annotation is defined on an instantiation assignment.Key Improvements
1. Pre-Constructor Template Binding
Previously, constructor parameters were evaluated before variable-level
@varannotations were processed. This caused generic constructors (__construct(array $items)) to infer template types dynamically from the first argument passed, rather than respecting the declared variable type contract.TypePHP now pre-binds the promised generic type to the instance before constructor parameter validation begins.
2. Heterogeneous Collection Initialization
Collections and generic containers initialized with multiple union subtypes now validate seamlessly without premature type-locking:
3. Immediate Constructor Boundary Failures
Invalid constructor arguments fail fast and report the exact parameter index where the invalid data was passed: