Skip to content

feat(periodic metrics): emit periodic metrics on latest green - #571

Closed
mnoah1 wants to merge 2 commits into
mainfrom
mnoah1/stovepipe-periodic-metrics
Closed

feat(periodic metrics): emit periodic metrics on latest green#571
mnoah1 wants to merge 2 commits into
mainfrom
mnoah1/stovepipe-periodic-metrics

Conversation

@mnoah1

@mnoah1 mnoah1 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Create a Reporter interface that can be called to take a snapshot of metrics at a current point in time
  • This can be used for things that need to be reported periodically, like the age of the latest green for a queue, and other future aspects of queue health
  • Wire into the record step so we have one call site. We can also schedule this as a periodic task in our internal service

Test Plan

  • Add in our service, and query on the emitted metrics

Verify failed-build detection age emission and last-known-green reporting
against the source-control and storage boundaries.

var _ observability.Reporter = (*reporter)(nil)

// New creates a Reporter for a queue's last-known-green age.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be done in record step itself? i am just wondering if it deserves to be it's own extension or not?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking that we can also schedule it separately on a periodic schedule (similar to ingest). Basically it can be called independently from wherever, and produces a real time snapshot of the metric.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the current PR is a duplicate - please see #572

@mnoah1
mnoah1 marked this pull request as ready for review August 11, 2026 22:47
@mnoah1
mnoah1 requested review from a team and sbalabanov as code owners August 11, 2026 22:47
@mnoah1

mnoah1 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Duplicate

@mnoah1 mnoah1 closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants