fix(messagequeue): drop the partition key from queue metric tags - #593
Merged
Conversation
Four topics derive partition keys from per-entity IDs — log and cancel from the request ID, build from the batch ID, buildsignal from the build ID — so tagging metrics with the key minted a permanent series family per request, batch, and build. Tally only reclaims a subscope when it is explicitly closed, and nothing closes per-partition scopes. Topic and consumer group stay, keeping per-stage latency and error rates intact, and partition identity is already in the structured logs. The per-queue breakdown on queue-partitioned topics goes with it; restoring it needs a bounded opt-in rather than tagging every topic.
mnoah1
marked this pull request as ready for review
August 14, 2026 20:28
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 14, 2026 20:28
behinddwalls
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Remove partition as a metric tag on the queue metrics.
What?
In the messaging queue, the controllers can set any partition value. We have several controllers throughout the services that have an effectively unbounded number of partitions being set (e.g. some use request ID or build ID to partition).
This results in dangerous metric cardinality when the partition gets used as a tag.