Skip to content

Particle Lagrangian stress history: an inflow cell is refilled from stale neighbours, not from inflow_value #783

Description

@lmoresi

`stress_transport="lagrangian"` (`uw.systems.ddt.Lagrangian`) keeps its swarm populated: the constructor installs a `population_control` and every `advection` ends with `repopulate`, refilling a starved cell from the bounded RBF reconstruction of its nearest particles and capping over-full cells. On a closed flow that is complete. On an open flow the value written into a refilled inflow cell is wrong:

Evidence: the 2026-09-23 domain-of-applicability sweep, cross-slot De 0.3, β 0, dt 0.2, refinement 1. The four mesh flavours complete (eulerian and forward steady at 61 steps; IP ran to the cap; nodal stalled). The Lagrangian cell recorded one DIVERGED_LINEAR_SOLVE, then hung at step 62 (t 12.4, domain length 10, unit inflow) for five hours at full CPU with no output and was killed by hand. The hang itself is not yet diagnosed and may be a separate defect.

Fix: honour `inflow_value` on `Lagrangian`. After the advection (and its repopulation), a particle whose one-step back-trace `x - u dt` leaves the domain entered through an inflow and takes the inflow datum in every history slot, the same test the integration-point flavour applies to a restored departure point.

Branch: `feature/forward-parallel` (no PR yet).

Activity

  1. changed the title [-]Particle Lagrangian stress history starves in open flows: no inflow injection, no repopulation, outflow particles clamped onto the boundary[/-] [+]Particle Lagrangian stress history: an inflow cell is refilled from stale neighbours, not from inflow_value[/+] on Sep 24, 2026
  2. lmoresi commented on Oct 7, 2026

    @lmoresi
    MemberAuthor

    Labelled fixed-in-PR. The fix is in #785, which is not merged — and cannot be: its base branch is feature/forward-parallel, which has no PR of its own, so the whole stack (#785 → #789 → #795 → #800) has nothing to merge into.

    #785 is green and mergeable against its base as of today, after the stack was refreshed with development. The work needed is a PR for the root, not anything on this issue.

    The label means the fix is written. It does not mean released. scripts/triage.py reports which PR and whether it has merged.

  3. added a commit that references this issue on Oct 8, 2026
  4. removed
    fixed-in-PRA PR carries the fix; the issue names it
    on Oct 8, 2026
  5. lmoresi commented on Oct 8, 2026

    @lmoresi
    MemberAuthor

    Fixed by #785, merged to development (719ef12d).

    The particle (Lagrangian) history now applies inflow_value to particles created at an inflow, using a cell-crossing horizon to decide which ones entered this step — rather than refilling them from stale neighbours.

    Closing manually: Closes lines here fire when development reaches main. Removing the fixed-in-PR label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions