fix(isCreditCard): fix mastercard prefix bug for short strings (#2717)#2743
Open
dweep-js wants to merge 1 commit into
Open
fix(isCreditCard): fix mastercard prefix bug for short strings (#2717)#2743dweep-js wants to merge 1 commit into
dweep-js wants to merge 1 commit into
Conversation
dweep-js
force-pushed
the
ismastercard-error
branch
from
0a19154 to
7fdc788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(isCreditCard): fix mastercard prefix bug for short strings
Wrapped the mastercard regular expression options in a non-capturing group
(?: ... ). This ensures that the start (^) and end ($) anchors apply to both parts of the OR (|) logic, preventing short strings like '5108' from falsely validating. Added a corresponding test case totest/validators.test.js.References: Closes #2717
Checklist