Skip to content

test: remove nextTestSetup deploy exclusion API - #98161

Open
gnoff wants to merge 1 commit into
jamiboym/deploy-gates/api-removal-basefrom
jstory/deploy-tests/remove-skip-api
Open

gnoff wants to merge 1 commit into
jamiboym/deploy-gates/api-removal-basefrom
jstory/deploy-tests/remove-skip-api

Conversation

@gnoff

@gnoff gnoff commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • remove skipDeployment and skipped from nextTestSetup after every caller has migrated to @force-gate
  • update the test review guidance to identify new deployment exclusions by their gate directive

This final layer makes @force-gate the only suite-scoped deployment exclusion mechanism.

The base is pinned to the original migration stack at 4c7272754c9b975625a1378eb4af42282c56825d so this PR retains its two-file diff while #98156, #98157, #98158, #98159, and #98160 land independently on canary. This PR still depends on the remaining App Router migration (#98155) and must be rebased only after all remaining callers have migrated.

Verification

  • verified on the combined top-of-stack tree with pnpm typescript
  • verified the feature-oriented stack has the same Git tree as the previously tested migration

@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: 09e79c0 | About building and testing Next.js

pnpm test-dev-turbo test/development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts (turbopack) (job)

  • instant-nav-panel > history traversals > shows real content on forward after back while awaiting navigation (DD)
  • instant-nav-panel > transitions between capture types > should keep the panel in MPA state after capture -> reload and then update to SPA state after client navigation (DD)
Expand output

● instant-nav-panel › transitions between capture types › should keep the panel in MPA state after capture -> reload and then update to SPA state after client navigation

locator.waitFor: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-testid="dynamic-skeleton"]') to be visible

  278 |     await browser
  279 |       .locator('[data-testid="dynamic-skeleton"]')
> 280 |       .waitFor({ state: 'visible' })
      |        ^
  281 |     await browser
  282 |       .locator('[data-testid="param-skeleton"]')
  283 |       .waitFor({ state: 'visible' })

  at waitFor (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:280:8)
  at Object.expectTargetPageSpaShell (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:794:13)

● instant-nav-panel › history traversals › shows real content on forward after back while awaiting navigation

locator.waitFor: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-testid="dynamic-skeleton"]') to be visible

  278 |     await browser
  279 |       .locator('[data-testid="dynamic-skeleton"]')
> 280 |       .waitFor({ state: 'visible' })
      |        ^
  281 |     await browser
  282 |       .locator('[data-testid="param-skeleton"]')
  283 |       .waitFor({ state: 'visible' })

  at waitFor (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:280:8)
  at Object.expectTargetPageSpaShell (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:870:13)

Other failing CI jobs

@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from 62cf291 to 33011dc Compare September 2, 2026 00:13
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 727f322 to b92b725 Compare September 2, 2026 00:14
@gnoff
gnoff marked this pull request as ready for review September 2, 2026 00:17
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from 33011dc to b5a622b Compare September 2, 2026 00:20
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from b92b725 to 3ad00b1 Compare September 2, 2026 00:20

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from b5a622b to 829336a Compare September 3, 2026 18:36
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 3ad00b1 to 4906349 Compare September 3, 2026 18:36
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from 829336a to f40dfd2 Compare September 4, 2026 18:05
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch 2 times, most recently from 8879463 to 967a34c Compare September 4, 2026 20:32
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from f40dfd2 to 0282df1 Compare September 4, 2026 20:32
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 967a34c to 285a779 Compare September 8, 2026 15:00
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch 2 times, most recently from 3341925 to b000c12 Compare September 8, 2026 23:32
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 285a779 to 2937617 Compare September 8, 2026 23:32
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from b000c12 to 3f152c8 Compare September 9, 2026 02:41
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 2937617 to 7290984 Compare September 9, 2026 02:41
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from 3f152c8 to 1854694 Compare September 9, 2026 15:25
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 7290984 to 279dcd1 Compare September 9, 2026 15:25
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from 1854694 to 817f833 Compare September 9, 2026 15:46
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 279dcd1 to ec26bd6 Compare September 9, 2026 15:46
@gnoff
gnoff removed this pull request from stack #98373 September 9, 2026 15:46
@gnoff
gnoff added this pull request to stack #98431 September 9, 2026 15:47
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from 817f833 to 9c984c5 Compare September 9, 2026 23:23
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from ec26bd6 to 09e79c0 Compare September 9, 2026 23:23
@gnoff
gnoff force-pushed the jstory/deploy-tests/remove-skip-api branch from 09e79c0 to c372883 Compare September 11, 2026 14:55
@gnoff
gnoff force-pushed the jstory/deploy-tests/mode-specific branch from 9c984c5 to 9f926c6 Compare September 11, 2026 14:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants