Report cache build status before stopping docker - #469
Merged
Conversation
pantherman594
approved these changes
Aug 27, 2026
pantherman594
left a comment
Contributor
There was a problem hiding this comment.
Hmm we're in a weird situation here. We want to clean up unnecessary files before saving the cache image, which we need to stop docker to do. But we need docker to write to the metadata. I think it should be fine since the signal to the cache builder is the instance shutting down, not the metadata getting set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache build reports its final status by calling set_metadata, which on GCP is a curl to the metadata server but on AWS tags the EC2 instance by running the AWS CLI in a container, so it cannot run after this script has masked and stopped the docker daemon.
Move the status write ahead of the docker stop so the AWS cache builder can tell a finished build from one that died, since it reads that status once the instance has powered itself off.
This changes nothing on GCP, where the call never depended on docker.
PHP-151845