-
Notifications
You must be signed in to change notification settings - Fork 185
feat(cli): Initialize a git repository and create an initial commit on scaffold #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8a13436
feat(cli): add flag to initialize a git repository
ryohidaka 6232ecf
feat(cli): create initial commit after scaffold completes
ryohidaka bd2a84e
fix(cli): respect --no-git flag when scaffolding monorepo
ryohidaka 9ef2832
fix(cli): warn when initial commit fails
ryohidaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
packages/cli/snap-tests/create-org-bundled-monorepo/steps.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "commands": [ | ||
| "node $SNAP_CASES_DIR/.shared/mock-npm-registry.mjs -- vp create @your-org:workspace --no-interactive --directory my-mono # bundled monorepo: extract tarball, scaffold, inject create.defaultTemplate", | ||
| "node $SNAP_CASES_DIR/.shared/mock-npm-registry.mjs -- vp create @your-org:workspace --no-interactive --directory my-mono --git # bundled monorepo: extract tarball, scaffold, inject create.defaultTemplate", | ||
| "cat my-mono/vite.config.ts # create.defaultTemplate auto-set to @your-org", | ||
| "cat my-mono/pnpm-workspace.yaml # workspace markers preserved", | ||
| "test -d my-mono/.git && echo 'Git initialized' || echo 'No git' # git-init prompt covers bundled monorepo path", | ||
| "test -d my-mono/.git && echo 'Git initialized' # git-init prompt covers bundled monorepo path", | ||
| "cat my-mono/.gitignore # node_modules excluded even though tarball shipped no .gitignore" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { runCommandSilently } from './command.ts'; | ||
|
|
||
| export async function initGitRepository(cwd: string): Promise<boolean> { | ||
| const result = await runCommandSilently({ | ||
| command: 'git', | ||
| args: ['init'], | ||
| cwd, | ||
| envs: process.env, | ||
| }); | ||
| return result.exitCode === 0; | ||
| } | ||
|
|
||
| export async function createInitialCommit(cwd: string): Promise<boolean> { | ||
| await runCommandSilently({ | ||
| command: 'git', | ||
| args: ['add', '-A'], | ||
| cwd, | ||
| envs: process.env, | ||
| }); | ||
| const result = await runCommandSilently({ | ||
| command: 'git', | ||
| args: ['commit', '-m', 'Initial commit from Vite+'], | ||
| cwd, | ||
| envs: process.env, | ||
| }); | ||
| return result.exitCode === 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -215,6 +215,30 @@ export async function promptGitHooks(options: { | |
| return true; // non-interactive default | ||
| } | ||
|
|
||
| export async function promptGitInit(options: { | ||
| git?: boolean; | ||
| interactive: boolean; | ||
| }): Promise<boolean> { | ||
| if (options.git === false) { | ||
| return false; | ||
| } | ||
| if (options.git === true) { | ||
| return true; | ||
| } | ||
| if (options.interactive) { | ||
| const selected = await prompts.confirm({ | ||
| message: 'Initialize a git repository with an initial commit?', | ||
| initialValue: false, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ryohidaka can you help me change the |
||
| }); | ||
| if (prompts.isCancel(selected)) { | ||
| cancelAndExit(); | ||
| return false; | ||
| } | ||
| return selected; | ||
| } | ||
| return false; // non-interactive default | ||
| } | ||
|
|
||
| export function defaultInteractive() { | ||
| // If CI environment, use non-interactive mode by default | ||
| return !process.env.CI && process.stdin.isTTY; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.