fix: add vite-plus/pack/client export as tsdown/client equivalent#1501
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9de06aa28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@naokihaba I just searched the global code on github again and found that there is already usage of importing Then we can create a new issue to handle the previously unimplemented todo items for tsconfig.json together, and rewrite both |
Thank you for checking! I understand that if these aren't rewritten during migration, they will break once tsdown is removed as a dependency — TypeScript won't be able to find the types, and imports will fail. I'll create a new issue to cover both:
|
fengmk2
added
test: e2e
…ements (#1541) resolves #1502 This PR depends on #1501. When you're ready, please make sure #1501, #1541, and #1542 are all merged together. I originally thought about including this in #1501, but I decided to pull it into a separate PR so the scope wouldn't get too wide. I figured it would be easier to review if we kept the Rust and TypeScript changes apart rather than mixing them into one. Let me know if you’d prefer a different merge strategy and I can easily adjust things.
…mpilerOptions.types (#1542) resolves #1502 This PR depends on #1501. When you're ready to merge, please make sure #1501, #1541, and #1542 are all merged at the same time. I thought about putting this together with #1501, but I decided to keep it separate so the scope didn't get too messy. I wanted to keep the Rust and TypeScript parts in different PRs to make the review a bit easier for everyone. If you’d prefer to have these combined for the merge, just let me know and I can adjust it. --------- Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
2 participants
resolves #1500