Repository navigation
Conversation
Author
|
Following up on the injected skill-experience lineage fix. Both current-head workflows are awaiting approval ( |
fukalous
force-pushed
the
fix/skill-experience-lineage
branch
from
October 10, 2026 16:16
c385397 to
4a31b4b
Compare
Author
|
Rebased cleanly onto current Fresh validation:
|
Author
|
@heaoxiang-ai this adjusts Experience trajectory lineage for injected skill memories in the area you originally implemented. The current head is mergeable and all applicable plugin and API/CLI checks are green. Could you review the lineage behavior when convenient? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The trajectory lineage pipeline only credited successful explicit
read/multi_readcalls. The Claude Code skill-experience hook injects retrieved Experience digests as text instead, so trajectories created from those sessions never carried source-experience tags and application statistics remained empty.This change recognizes the exact envelope and bullet format emitted by the bundled hook, then sends each candidate through the existing current-user Experience URI validation before adding it to lineage. Explicit reads and injected URIs share the existing ordered de-duplication path.
Human Involvement
Related Issue
Fixes #5405
Type of Change
Changes Made
skill-experience/experience-digestcontext envelope.canonical_experience_uri()to reject other-user and non-Experience paths.Testing
Commands run:
The focused mypy invocation traverses the repository and reports the existing main-branch type-error baseline; it reports no error in the changed lineage module.
Checklist
Additional Notes
The parser intentionally accepts only the exact envelope and generated list-item shape owned by
skill-experience.mjs; ordinary auto-recall context and lookalike text outside that envelope are ignored. No claim of independent human review is made.