Repository navigation
Conversation
sponge225
approved these changes
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
viking_healthprefers the SDK'sget_status(), which returnsis_healthy, but the adapter only recognized other health fields. Healthy and unhealthy SDK responses both becamestate: "unknown".Recognize a boolean
is_healthyafter the existinghealthy/okand recognizedstatus/statevalues, preserving their precedence. Include the flag in the existing safe summary; raw errors and component details remain excluded. Server health computation and SDK behavior are unchanged.Human Involvement
Related Issue
Fixes #5876.
Type of Change
Changes Made
Extend the existing public-tool safe-summary test to cover canonical booleans, conflicting legacy fields, and a non-boolean flag.
Testing
SyncHTTPClient.get_status()→ publicviking_health: 10 controls / 20 HTTP requests. Unmodified main fails the two canonical boolean controls; this change passes all 10, including legacy precedence and safe-summary controls. This tests response consumption, not a deployed OpenViking backend or model service.python -m pytest --noconftest -o addopts= -q tests/unit/test_langchain*.py tests/integration/langchain_langgraph: 218 passed, 1 skipped, with 68 existing deprecation/future warnings. The skipped host-summary persistence test requires the optionallanggraph.checkpoint.sqlitepackage, which is not installed in this isolated environment.ruff format --checkandruff checkon both changed files: passed.mypy --config-file examples/langchain/pyproject.toml examples/langchain/src/langchain_openviking: passed (15 source files).git diff --check: passed.Python 3.12.14 / macOS arm64. Hosted CI remains to be observed.
Checklist