Repository navigation
fix(kit): guard reinstall and stale plugin replay - #1166
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vue-devtools-docs canceled.
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small hardening fixes for the kit lifecycle. Neither is reachable through the Vite or Chrome hosts today.
dispose()clears the runtime handlers, RPC and plugins, butinstall()resetdisposedand reinstalled the hook. The result was a kit that connected but failed every query withUnknown runtime query.install()on a disposed kit is now a no-op with a warning to create a new kit. Both hosts already create a new kit after dispose.setupDevToolsPlugincalls are buffered globally so a later kit can replay them, but entries were never removed. A new kit on the same page (e.g. after HMR of the Vite injection withappendTo) re-ran setups for apps that had already unmounted. The plugin controller now drops buffered entries for an app onapp:unmount. Setups for mounted apps, or without an app, are still replayed. This only affects plugins using the v9setupDevToolsPlugin; Pinia and Vue Router use the v8 API, which isn't buffered.Verification
New
tests/unit/plugin/kit-lifecycle.test.ts:main)main)Unit and integration tests pass (369),
tscon the kit and lint are clean.🤖 Generated with Claude Code