Repository navigation
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeline event rows in v9 are clickable divs, so keyboard users cannot focus or activate them to inspect an event.
Render each event row as a native
buttonwithtype="button". This provides Tab, Enter, and Space behavior through the existing selection and inspection callback. Expose the selected event witharia-pressed, retain the full event title, subtitle, and timestamp in the accessible name (including grouped rows that hide repeated titles), and add an inset keyboard focus outline. Keep the existing virtual scroller, 28px row height, and mouse selection behavior.Add an Issue #885 regression test for native button semantics, focusability, accessible names, selection state, inspection callbacks, and repeated activation. Both tests fail on the original code and pass with this change.
Relates to #885. This is limited to Timeline event rows; the issue also tracks other accessibility work.
Validation
pnpm test: 68 files, 407 tests passed, including the two new regression tests.pnpm typecheck,pnpm lint,pnpm format:check, andpnpm check: passed.pnpm buildseparately in PowerShell to preserve the quoted package filters:pnpm --filter './packages/*' --filter '!vite-plugin-vue-devtools' -r buildpnpm --filter vite-plugin-vue-devtools buildgit diff --check: passed.The integration test stubs layout and scrolling; native key activation and virtualization were checked separately in the browser fixture. Full host smoke suites and screen-reader testing were not run.