fix(store): restore default tsconfig in setFiles#400
Open
ifer47 wants to merge 1 commit into
Open
Conversation
|
@ifer47 is attempting to deploy a commit to the vuejs Team on Vercel. A member of the Team first needs to authorize it. |
ifer47
marked this pull request as ready for review
July 20, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tsconfig.jsonwheneversetFiles()receives no tsconfig.tsconfig.jsonunchanged.Why
setFiles()replaces the store's entire file record. Store initialization adds a defaulttsconfig.json, but the replacement path did not restore that default, so language tooling lost its configuration after callers replaced only their source files.Fixes #383.
How tested
pnpm testpnpm typecheckpnpm lintpnpm exec prettier --check src/store.ts test/store.test.mjs package.jsonpnpm build(passes; retains the existing API Extractor warning about its bundled TypeScript version)Risk and rollout
setFiles()omits it; caller-provided tsconfig content still wins.Notes for reviewers
src/store.ts; and behavior/API terms.383,setFiles tsconfig,tsconfig.json,src/store.ts setFiles, andUsing setFiles removes tsconfig.json.setFilesremoves tsconfig.json #383. The broadtsconfig.jsonsearch only found unrelated PRs chore(deps): update all non-major dependencies #251 (dependency updates) and feat: support ts importtypemodifiers on import names #28 (TypeScript import modifiers).setFilescommits177f675and424e00dpredate the tsconfig feature; PR feat: add tsconfig file #114 added tsconfig support but did not restore it aftersetFiles().