Repository navigation
chore: build the visual reporter with Vite 8 - #1294
Merged
Merged
Conversation
Remix 2 supports Vite 5 and 6 (peer ^5.1.0 || ^6.0.0), so Vite 6 is the first step before the move to React Router. The built report is pixel-identical to the Vite 5 build (home view and comparison overlay of the demo report), and the GitHub Pages build keeps its base path. Replaces Dependabot webdriverio#1267, which did not update pnpm-lock.yaml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Remix 2 is in maintenance and supports only React 18, Vite 5/6 and TypeScript 5. React Router 7 is its successor (framework mode) and supports React 18/19, Vite 5 to 8 and TypeScript 5/6. - @remix-run/* -> react-router, @react-router/dev, @react-router/node. - react-router.config.ts (ssr: false, the GitHub Pages basename) and app/routes.ts (the single index route). - Entries: HydratedRouter / ServerRouter; abortDelay -> streamTimeout. - Scripts: react-router build / dev; start serves build/client with sirv, like the CLI (remix-serve needed a server build, which a single-page app does not have, so start did not work). The built report is pixel-identical to the Remix build (home view and comparison overlay of the demo report), also under the GitHub Pages base path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
React Router 7 supports React 18 and 19, so React 19 is now possible. react-select 5.10 and react-icons 5.7 accept React 19. With @types/react 19, useRef<T>(null) returns RefObject<T | null>, so the canvasRef type of the drawing hook allows null (the hook already checks it). The built report is pixel-identical (home view and comparison overlay of the demo report), and the Status filter (react-select) works. Replaces Dependabot webdriverio#1264. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
React Router 7 supports Vite 5 to 8. Vite 8 resolves the tsconfig paths itself (resolve.tsconfigPaths), so the vite-tsconfig-paths plugin is removed; that also removes the last TypeScript 6 peer warning (its tsconfck dependency wanted TypeScript 5). The built report is pixel-identical (home view and comparison overlay of the demo report, also under the GitHub Pages base path), and the Status filter works. Replaces Dependabot webdriverio#1263. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
plum117
marked this pull request as ready for review
October 9, 2026 01:37
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 4 (last) of the visual reporter upgrade: Vite 6 → 8 (replaces Dependabot #1263).
React Router 7 supports Vite 5 to 8. Vite is a development dependency of the reporter (it builds the static report UI); users do not install it.
Changes
vite^6.4.4→^8.3.3(8.3.4 was published today and is blocked by the 1-dayminimumReleaseAge).vite-tsconfig-pathsis removed: Vite 8 resolves the tsconfigpathsitself (resolve.tsconfigPaths: true) for our~/*alias. This also removes the last TypeScript 6 peer warning, which came from itstsconfckdependency (typescript ^5).Test
/visual-testing/).react-select) works ("Passed" → 19 cards, "Failed" → 17). No browser console errors.typecheck, Oxlint,pnpm test(1077 unit tests), frozen install: pass.pnpm peers check: no TypeScript peer warning any more.SelectHeader.tsxsourcemap message of the old builds is gone with Vite 8.No changeset: development dependencies only, and the built UI does not change.
The whole reporter track
After all of them: close #1267, #1264 and #1263 (Dependabot), which these PRs replace.
🤖 Generated with Claude Code