Skip to content

chore: move the visual reporter to React Router 8 - #1300

Merged
plum117 merged 1 commit into
webdriverio:mainfrom
plum117:chore/reporter-react-router-8
Oct 9, 2026
Merged

plum117 merged 1 commit into
webdriverio:mainfrom
plum117:chore/reporter-react-router-8

Conversation

@plum117

@plum117 plum117 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves the visual reporter from React Router 7.18 to 8.4 (released 2026-06-17).

React Router is a development dependency of the reporter: it is bundled into the static report UI (build/client). Users do not install it, and their own projects are not affected.

Requirements

  • React 19.2.7+ (we have 19.3) and Vite 7+ (we have 8.3): met.
  • Node.js 22.22+ to build the reporter. CI and the release use Node.js 24 (.nvmrc). Contributors on Node.js 22.19–22.21 get an engine warning when they build the reporter. Users of the published package are not affected (they get the built files).

Changes

  • react-router, @react-router/dev, @react-router/node: ^7.18.4 → ^8.4.0.
  • app/entry.server.tsx: remove the unused loadContext parameter; React Router 8 no longer exports AppLoadContext (replaced by the middleware context).
  • .npmignore: React Router 8 keeps the small server build that renders index.html in single-page app mode (build/server, 8 KB; React Router 7 removed it). The CLI only serves build/client, so build/server is not published (npm pack --dry-run: no build/server).

The other breaking changes of React Router 8 (Cloudflare proxy, future.* flags removed, splitRouteModules default, Vite Environment API always on) do not touch this app: one route, no loaders or actions, no future flags. The "future flag" warnings of the React Router 7 build are gone.

Test

  • The built UI is pixel-identical to the React Router 7 build on main: the demo report served and opened in headless Chrome, home view and comparison overlay: 0 different pixels. Also under the GitHub Pages base path (/visual-testing/).
  • The Status filter works ("Passed" → 19 cards, "Failed" → 17), no browser console errors.
  • Reporter typecheck, Oxlint, pnpm test (1079 unit tests), frozen install: pass.

No changeset of its own: the built UI does not change. The pending reporter changeset (UI rebuilt with new libraries) will mention React Router 8.

🤖 Generated with Claude Code

React Router 8 needs React 19.2.7+ and Vite 7+ (we have React 19.3 and
Vite 8). Its breaking changes do not touch our single-route single-page
app: no Cloudflare, no loaders or actions, no future flags in use.

- entry.server.tsx: remove the unused loadContext parameter; React
  Router 8 no longer exports AppLoadContext.
- .npmignore: React Router 8 keeps the small server build that renders
  index.html (build/server, 8 KB); the CLI only serves build/client, so
  build/server is not published.

React Router 8 needs Node.js 22.22+ to build the reporter (CI uses
Node.js 24). The built report is pixel-identical to the React Router 7
build, also under the GitHub Pages base path, and the filters work.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c9813f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@plum117
plum117 marked this pull request as ready for review October 9, 2026 10:21
@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable defects were found.

Summary

Updates the visual reporter’s React Router development dependencies from 7.18.4 to 8.4.0.

  • The visual reporter builds with React Router 8.

No actionable issues were found. This review checked code and configuration; it did not run builds or browser tests.

Acknowledgments: plum117 explicitly accepts the engine warning for contributors using Node 22.19–22.21. plum117 also intentionally omits a separate changeset because the pending reporter changeset will cover the rebuilt UI.

Reviews (1) · Last reviewed commit: "chore: move the visual reporter to React..." · Reviewed by Greptile

@plum117
plum117 merged commit 7d9bb3b into webdriverio:main Oct 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants