Repository navigation
build: keep the browser support of the visual report (Chrome 87+, Safari 14+) - #1305
Merged
Merged
Conversation
…ari 14+) Vite 8 builds for 'baseline-widely-available' by default (Chrome/Edge 111+, Firefox 114+, Safari 16.4+), and Vite 7 removed the 'modules' target that Vite 5 used. Set the same browser list explicitly. All bundles now parse as ES2020 (5 did not before), and the report screenshots are pixel-identical. Update the v11 guide and the reporter changeset (patch: no browser is dropped any more). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| Name | Type |
|---|---|
| @wdio/visual-reporter | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
plum117
marked this pull request as ready for review
October 9, 2026 11:48
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vite 8 builds for its default target
'baseline-widely-available': Chrome/Edge 111+, Firefox 114+, Safari 16.4+. Vite 5 (reporter 0.4.15) used the'modules'target: Chrome 87+, Edge 88+, Firefox 78+, Safari 14+. Without a change, v11 of the reporter would drop those older browsers. The report is often opened in another browser than the one under test (for example a CI artifact opened on a laptop), so we keep the old support. Vite 7 removed the'modules'value, so the list is set explicitly.What
packages/visual-reporter/vite.config.ts:build.target: ['es2020', 'edge88', 'firefox78', 'chrome87', 'safari14'](the values of Vite 5's'modules'target), with a comment.docs/v11-migration.md: the browser support of the report does not change..changeset/visual-reporter-react-router.md: the same text; patch instead of minor (no browser is dropped any more; the reporter still gets a minor from the Node.js engines changeset).The CSS does not limit the browsers: the report uses plain CSS. Tailwind is in the dev dependencies, but its PostCSS plugin is commented out and no file imports
app/tailwind.css.Test
build/client/assetsparsed with acorn as ES2020. With the Vite 8 default: 5 bundles fail (for example private class fields#). With this change: all bundles parse.pnpm build+pnpm script:prepare.report), served withsirv, screenshots with WebdriverIO in Chrome (home, after the first click): 0 different pixels between the Vite 8 default and this change.pnpm --filter @wdio/visual-reporter typecheckandpnpm test:lintpass.🤖 Generated with Claude Code