feat(ui): add navbar and footer#115
Open
avivkeller wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds site chrome for the webpack doc-kit app, including navigation/footer data and theme aliases, with a new layout hook for custom page layouts.
Changes:
- Adds navbar/footer site configuration and corresponding React components.
- Registers new theme imports for navigation, footer, and logo.
- Updates layout selection and refreshes lockfile dependency metadata.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/prepare/index.mjs |
Enables shell execution for prepare script child processes. |
scripts/html/doc-kit.config.mjs |
Adds aliases for Navigation, Footer, and Logo components. |
pages/site.json |
Adds navbar and footer configuration. |
package-lock.json |
Updates resolved dependency metadata. |
layouts/Home/index.jsx |
Adds a home layout component. |
components/WebpackLogo/Icon.jsx |
Adds webpack SVG logo component. |
components/NavBar.jsx |
Adds navbar UI using configured links, search, theme toggle, and GitHub icon. |
components/Layout.jsx |
Selects custom layouts based on page metadata. |
components/Footer/index.module.css |
Adds footer styling. |
components/Footer/index.jsx |
Adds footer UI using configured link groups and social links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bjohansebas
reviewed
May 31, 2026
bjohansebas
reviewed
May 31, 2026
bjohansebas
reviewed
May 31, 2026
bjohansebas
reviewed
May 31, 2026
bjohansebas
reviewed
May 31, 2026
Comment on lines
+28
to
+31
| <a | ||
| href="https://github.com/webpack/webpack" | ||
| className={styles.ghIconWrapper} | ||
| > |
bjohansebas
reviewed
May 31, 2026
| ], | ||
| "sidebar": [], | ||
| "footer": { | ||
| "socialLinks": [ |
bjohansebas
reviewed
May 31, 2026
| }, | ||
| { | ||
| "text": "Code of Conduct", | ||
| "link": "https://github.com/webpack/webpack/blob/main/CODE_OF_CONDUCT.md" |
Member
There was a problem hiding this comment.
404 link, the new location is https://github.com/webpack/.github/blob/main/.github/CODE_OF_CONDUCT.md
bjohansebas
reviewed
May 31, 2026
| "links": [ | ||
| { | ||
| "text": "Contribute", | ||
| "link": "https://github.com/webpack/webpack/blob/main/CONTRIBUTING.md" |
Member
There was a problem hiding this comment.
Suggested change
| "link": "https://github.com/webpack/webpack/blob/main/CONTRIBUTING.md" | |
| "link": "https://github.com/webpack/.github/blob/HEAD/.github/CONTRIBUTING.md" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a header and footer component, per the design in #96. The page itself is yet to be written.
See: https://webpack-doc-kit-git-add-header-footer-openjs.vercel.app/api/v5.x