Skip to content

fix: disable pending message retry on app open #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MohamadJaara wants to merge 1 commit into from
Closed

fix: disable pending message retry on app open #5211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/src/main/kotlin/com/wire/android/GlobalObserversManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ class GlobalObserversManager @Inject constructor(
}
scope.handleLogouts()
scope.handleDeleteEphemeralMessageEndDate()

if (kaliumConfigs.pendingMessages) {
scope.retryPendingMessagesOnAppOpen()
}
}

private suspend fun setUpNotifications() {
Expand Down
8 changes: 4 additions & 4 deletions app/src/test/kotlin/com/wire/android/GlobalObserversManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,15 @@ class GlobalObserversManagerTest {
}

@Test
fun `given app visible and valid session, when app opens, then retry sending pending messages`() {
fun `given app visible and valid session, when app opens, then do not retry sending pending messages`() {
val (arrangement, manager) = Arrangement()
.withCurrentSession(CurrentSessionResult.Success(AccountInfo.Valid(TestUser.SELF_USER.id)))
.withAppVisibleFlow(true)
.arrange()

manager.observe()

coVerify(exactly = 1) { arrangement.sendPendingMessagesAfterForegroundSync(TestUser.SELF_USER.id) }
coVerify(exactly = 0) { arrangement.sendPendingMessagesAfterForegroundSync(any()) }
}

@Test
Expand Down Expand Up @@ -257,7 +257,7 @@ class GlobalObserversManagerTest {
}

@Test
fun `given valid session when app becomes visible then retry sending pending messages`() {
fun `given valid session when app becomes visible then do not retry sending pending messages`() {
val appVisibleFlow = MutableStateFlow(false)
val (arrangement, manager) = Arrangement()
.withCurrentSession(CurrentSessionResult.Success(AccountInfo.Valid(TestUser.SELF_USER.id)))
Expand All @@ -269,7 +269,7 @@ class GlobalObserversManagerTest {

appVisibleFlow.value = true

coVerify(exactly = 1) { arrangement.sendPendingMessagesAfterForegroundSync(TestUser.SELF_USER.id) }
coVerify(exactly = 0) { arrangement.sendPendingMessagesAfterForegroundSync(any()) }
}

@Test
Expand Down
Loading