NewStoredUser: Remove handle - #5475
Merged
Merged
Conversation
zebot
added
the
ok-to-test
fisx
reviewed
Aug 25, 2026
fisx
left a comment
fisx
left a comment
Contributor
There was a problem hiding this comment.
so, we wrote the handle into the StoredUser, but it wasn't claimed yet. and now we're not, and instead we get the handle from -- where?
looks plausible, but i'd like to understand it better.
The cassandra interpreter was storing the handle without "claiming" it, expecting the caller to make a subsequent call to claim the handle. The postgresql interpreter was claiming it unsafely, so it'd throw a 500 if the handle was already claimed. Removing the handle from this type seems the more correct way where the calling party must make a subsequent call to claim the handle and deal with this partial failure in creating a user.
akshaymankar
force-pushed
the
remove-handle-from-new-stored-user
branch
from
August 25, 2026 09:04
5893f2e to
e17d4b9
Compare
fisx
approved these changes
Aug 25, 2026
akshaymankar
force-pushed
the
remove-handle-from-new-stored-user
branch
from
August 25, 2026 14:03
005de33 to
230bc67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cassandra interpreter was storing the handle without "claiming" it, expecting the caller to make a subsequent call to claim the handle.
The postgresql interpreter was claiming it unsafely, so it'd throw a 500 if the handle was already claimed.
Removing the handle from this type seems the more correct way where the calling party must make a subsequent call to claim the handle and deal with this partial failure in creating a user.
Checklist
changelog.d.