Update url on navigation [WPB-27977] - #22271
Merged
Merged
Conversation
thisisamir98
requested changes
Aug 21, 2026
thisisamir98
left a comment
thisisamir98
left a comment
Collaborator
There was a problem hiding this comment.
Meetings URL restore on refresh looks good.
Clearing the hash to / can reopen the last conversation and steal Cells or Connect a tick later. Please fix that race before merge.
If Meetings is turned off while that tab is selected, also clear #/meetings. The tab-keep tests should lock a successful showConversation, not a thrown lookup.
Covers Connect/Preferences/Cells/Meetings switching, conversation list tabs, and refresh staying on Meetings (WPB-27977).
Folders is a toggle, not an aria-selected tab, and a new team has no conversation search field.
Format conversations.test.tsx for Prettier and drop an unused pages binding that failed noUnusedLocals.
…luation in URL navigation
zskhan
force-pushed
the
feat/update-url-on-navigation
branch
from
August 25, 2026 09:46
48f0685 to
413bfef
Compare
jest.spyOn failed at runtime because the test double omitted sendConnectionRequest and saveConversation after the type-check workaround.
thisisamir98
approved these changes
Aug 25, 2026
thisisamir98
enabled auto-merge
August 25, 2026 10:46
thisisamir98
disabled auto-merge
August 25, 2026 10:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.