Allow editing ongoing meetings without dropping them from the list [WPB-27894] - #22281
Merged
Conversation
Use today's in-progress occurrence as the edit anchor instead of the next upcoming instance, allow edit until occurrence end, and skip client past-time validation on update while create keeps existing checks.
Lock in WPB-27894: edit stays available until the occurrence ends, today's slot is submitted instead of the next instance, and create still rejects past start times.
Replace CRUD and ticket-based names with Schedule, Edit, Participants, Delete, Notifications, and Call, and keep all cases in one spec.
The create mapper still omitted mode after validation started requiring it, which failed type-check. Create continues to reject past start times.
Stop synthesizing a post-until occurrence as the edit anchor, lock edit-mode validation that must still fail closed, and cover title-only edit of a future list row so today's in-progress slot stays in the list.
CI lint:format failed because the meetingTime.util import was split across lines.
zskhan
previously approved these changes
Aug 24, 2026
Review asked for the shared helper instead of === undefined; apply it to the sibling conditions in those functions as well.
zskhan
approved these changes
Aug 25, 2026
Contributor
First appeared in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on backend WPB-28080 (24h past
start_timeon update).Test plan
yarn playwright test --config apps/webapp/playwright.config.ts apps/webapp/test/e2e_tests/specs/Meetings/meetings.spec.ts