Skip to content

"wix extension remove": delete only extension folder, print status messages - #734

Open
WolfgangHG wants to merge 1 commit into
wixtoolset:mainfrom
WolfgangHG:extension_remove
Open

WolfgangHG wants to merge 1 commit into
wixtoolset:mainfrom
WolfgangHG:extension_remove

Conversation

@WolfgangHG

Copy link
Copy Markdown

This resolves part one of https://github.com/orgs/wixtoolset/discussions/9313 (I am the same person that wrote this ticket, but it's a different github account): wix extension remove extensionname/id just killed the full cache folder instead of deleting only the extension folder and thus removed all other extensions.

This is hopefully a trivial fix, but I also tried to improve diagnostics output, because currently, you enter the command and there is no feedback whether it was successful or not.

So I added a warning message that is written if the extension is not found, and I added a auccess message.

In case of a wrong extension reference specification, this is printed:

wix extension remove -g "WixToolset.Util.wixext/7.0.2"
WixToolset.Util.wixext : warning WIX6102: Extension WixToolset.Util.wixext with Id 7.0.2 not found in C:\Users\USERNAME\.wix\extensions\WixToolset.Util.wixext\7.0.2.

I case of success:

wix extension remove -g "WixToolset.Util.wixext/7.0.0"
wix.exe : information WIX6200: Removed extension folder C:\Users\USERNAME\.wix\extensions\WixToolset.Util.wixext\7.0.0

As there was a class ExtensionCacheWarnings, I added a similar class ExtensionCacheInformations. This is probably no good idea, as the message ids should not overlap. Maybe rename ExtensionCacheWarnings to ExtensionCacheMessages and name the methods with a Warning or Information prefix?

Hope you consider the idea of better feedback messages reasonable 😄 .

Is there anything else that I need to update? Unit tests?

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@WolfgangHG

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

wixbot added a commit to wixtoolset/.github that referenced this pull request Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant