Repository navigation
"wix extension remove": delete only extension folder, print status messages - #734
Open
WolfgangHG wants to merge 1 commit into
Open
WolfgangHG wants to merge 1 commit into
WolfgangHG wants to merge 1 commit into
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
wixbot
added a commit
to wixtoolset/.github
that referenced
this pull request
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves part one of https://github.com/orgs/wixtoolset/discussions/9313 (I am the same person that wrote this ticket, but it's a different github account):
wix extension remove extensionname/idjust killed the full cache folder instead of deleting only the extension folder and thus removed all other extensions.This is hopefully a trivial fix, but I also tried to improve diagnostics output, because currently, you enter the command and there is no feedback whether it was successful or not.
So I added a warning message that is written if the extension is not found, and I added a auccess message.
In case of a wrong extension reference specification, this is printed:
I case of success:
As there was a class
ExtensionCacheWarnings, I added a similar classExtensionCacheInformations. This is probably no good idea, as the message ids should not overlap. Maybe renameExtensionCacheWarningstoExtensionCacheMessagesand name the methods with aWarningorInformationprefix?Hope you consider the idea of better feedback messages reasonable 😄 .
Is there anything else that I need to update? Unit tests?