Add cross-provider tests for ML-DSA and ML-KEM - #493
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
padelsbach
force-pushed
the
test-pqc-cross-provider
branch
from
October 1, 2026 00:12
c466ab6 to
5432e20
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The test-only changes correctly exercise bidirectional provider interoperability with appropriate cleanup and validation.
Review effort: Balanced
Findings: None
What changed in this PR
Adds unit-level cross-provider interoperability coverage for ML-KEM and ML-DSA raw keys.
Changes:
- Tests bidirectional raw-key transfers between wolfProvider and OpenSSL.
- Validates cross-provider encapsulation, decapsulation, signing, and verification.
- Registers the new tests in the unit-test suite.
| File | Description |
|---|---|
test/unit.h |
Declares the new tests. |
test/unit.c |
Registers the new tests. |
test/test_mlkem.c |
Adds ML-KEM raw-key interoperability tests. |
test/test_mldsa.c |
Adds provider-aware helpers and ML-DSA interoperability tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
padelsbach
force-pushed
the
test-pqc-cross-provider
branch
from
October 1, 2026 17:56
5432e20 to
6f42897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increases coverage and compatibility validation